From: dai.ngo@oracle.com
To: Chuck Lever III <chuck.lever@oracle.com>,
Benjamin Coddington <bcodding@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"linux-nfs@stwm.de" <linux-nfs@stwm.de>
Subject: Re: [PATCH 1/3 v2] SUNRPC: remove printk when back channel request not found
Date: Wed, 20 Dec 2023 08:45:59 -0800 [thread overview]
Message-ID: <368736f6-7eea-481d-b61c-513df246c554@oracle.com> (raw)
In-Reply-To: <30058A8C-7A1B-4C48-A13B-B071424FADDC@oracle.com>
Thank you Ben and Chuck,
I will add a counter in svc_stat as replacement for the printk.
-Dai
On 12/20/23 5:54 AM, Chuck Lever III wrote:
>
>> On Dec 20, 2023, at 8:04 AM, Benjamin Coddington <bcodding@redhat.com> wrote:
>>
>> On 18 Dec 2023, at 10:05, Chuck Lever III wrote:
>>
>>> If you have one or two bugs that are public I could look at,
>>> I would be really interested in what you find with this failure
>>> mode.
>> After a full-text search of bugzilla, I found only three bugs with this
>> printk -- and all three were cases of kernel memory corruption or a
>> crashed-then-restarted server.
>>
>> It's probably safe to ignore my feelings on this one. :)
> Thank you for checking!
>
>
> --
> Chuck Lever
>
>
next prev parent reply other threads:[~2023-12-20 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 21:47 [Patch 0/3 v2] Bug fixes for NFSD callback Dai Ngo
2023-12-15 21:47 ` [PATCH 1/3 v2] SUNRPC: remove printk when back channel request not found Dai Ngo
2023-12-16 9:52 ` kernel test robot
2023-12-16 11:12 ` Benjamin Coddington
2023-12-16 16:39 ` Chuck Lever III
2023-12-18 12:48 ` Benjamin Coddington
2023-12-18 15:05 ` Chuck Lever III
2023-12-20 13:04 ` Benjamin Coddington
2023-12-20 13:54 ` Chuck Lever III
2023-12-20 16:45 ` dai.ngo [this message]
2023-12-20 19:05 ` Chuck Lever III
2023-12-15 21:47 ` [PATCH 2/3 v2] NFSD: restore delegation's sc_count if nfsd4_run_cb fails Dai Ngo
2023-12-15 21:47 ` [PATCH 3/3 v2] NFSD: Fix server reboot hang problem when callback workqueue is stuck Dai Ngo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=368736f6-7eea-481d-b61c-513df246c554@oracle.com \
--to=dai.ngo@oracle.com \
--cc=bcodding@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@stwm.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox