Re: Readdirplus compatibility fix for IRIX server

[Steve Dickson <SteveD@RedHat.com>]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

Trond Myklebust wrote:

>Your patch is merely short-circuiting that recovery mechanism
>
Exactly.... I realized this as soon as I hit the Send button. :-(
Here is a patch that explicitly fixes the problem and only
effects READDIRPLUSs

SteveD


[-- Attachment #2: linux-2.4.22-nfs-readdirplus-irix.patch --]
[-- Type: text/plain, Size: 543 bytes --]

--- linux-2.4.22/fs/nfs/dir.c.org	2003-12-09 14:21:59.000000000 -0500
+++ linux-2.4.22/fs/nfs/dir.c	2003-12-11 05:50:26.000000000 -0500
@@ -437,6 +437,14 @@ static int nfs_readdir(struct file *filp
 				if (res >= 0)
 					continue;
 			}
+			/*
+			 * Some IRIX servers fail READDIRPLUS RPC calls
+			 * with NFSERR_TOOSMALL when a non-existent cookie 
+			 * is requested, which is a bug. So ignore that failure.
+			 */
+			if (desc->plus && desc->error == -ETOOSMALL)
+				desc->error = 0;
+
 			res = 0;
 			break;
 		} else if (res < 0)