From: Steve Dickson <steved@redhat.com>
To: Scott Mayhew <smayhew@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH] nfsd: dump default number of threads to 16
Date: Sat, 23 Nov 2024 14:53:26 -0500 [thread overview]
Message-ID: <3ecdde1f-b92a-4675-b0f9-3ed120827461@redhat.com> (raw)
In-Reply-To: <20241118202011.1115968-1-smayhew@redhat.com>
On 11/18/24 3:20 PM, Scott Mayhew wrote:
> nfsdctl defaults to 16 threads. Since the nfs-server.service file first
> tries nfsdctl and then falls back to rpc.nfsd, it would probably be wise
> to make the default in rpc.nfsd and nfs.conf 16, for the sake of
> consistency and to avoid surprises.
>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed... (tag: nfs-utils-2-8-2-rc3)
steved.
> ---
> nfs.conf | 2 +-
> utils/nfsd/nfsd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/nfs.conf b/nfs.conf
> index 23b5f7d4..087d7372 100644
> --- a/nfs.conf
> +++ b/nfs.conf
> @@ -66,7 +66,7 @@
> #
> [nfsd]
> # debug=0
> -# threads=8
> +# threads=16
> # host=
> # port=0
> # grace-time=90
> diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c
> index 249df00b..f787583e 100644
> --- a/utils/nfsd/nfsd.c
> +++ b/utils/nfsd/nfsd.c
> @@ -32,7 +32,7 @@
> #include "xcommon.h"
>
> #ifndef NFSD_NPROC
> -#define NFSD_NPROC 8
> +#define NFSD_NPROC 16
> #endif
>
> static void usage(const char *);
prev parent reply other threads:[~2024-11-23 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 20:20 [nfs-utils PATCH] nfsd: dump default number of threads to 16 Scott Mayhew
2024-11-18 20:24 ` Scott Mayhew
2024-11-19 17:07 ` Jeff Layton
2024-11-23 19:53 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ecdde1f-b92a-4675-b0f9-3ed120827461@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox