Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Charles Lever <Charles.Lever@netapp.com>, nfs@lists.sourceforge.net
Subject: Re: [PATCH]  Reinstantiating stale inodes
Date: Fri, 23 Apr 2004 12:16:11 -0400	[thread overview]
Message-ID: <4089414B.8090102@RedHat.com> (raw)
In-Reply-To: <1082732429.2617.35.camel@lade.trondhjem.org>

Trond Myklebust wrote:

>On Fri, 2004-04-23 at 10:48, Lever, Charles wrote:
>  
>
>>there appears to be a real problem when restoring from a backup,
>>or using rsync.  the file size and the mtime stay precisely the
>>same, but the file handle changes.  i'm not sure anything can be
>>done about this in NFSv2/3?
>>    
>>
>
>The only way to distinguish the two is to replace the use of the mtime
>with the ctime in nfs_check_verifier() and friends.
>  
>
Again.. this was the first place I looked... And I just can't figure how
to use NFS_CACHE_CTIME() in any meaningful calculation...

>Under ordinary circumstances, the mtime and ctime should be more or less
>identical, 
>
In this particular case they aren't because the server explicitly
maintains the "old" mtime and since mtime does not change we'll never
get the new ctime...

>so I'm not sure why Steve was seeing extra revalidations when
>he was running the Connectathon suite. Were you perhaps changing the
>algorithm in nfs_refresh_inode() instead, Steve?
>  
>
A very keen observation... Yes, when I introduced ctime into the valid or
not valid calculation, the getattrs (i.e revalidations) but even more
surprising (at least to me) was the number of reads sky rocked when
I ran the cthon tests...

SteveD.


-------------------------------------------------------
This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek
For a limited time only, get FREE Ground shipping on all orders of $35
or more. Hurry up and shop folks, this offer expires April 30th!
http://www.thinkgeek.com/freeshipping/?cpg=12297
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2004-04-23 16:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-23 14:48 [PATCH] Reinstantiating stale inodes Lever, Charles
2004-04-23 15:00 ` Trond Myklebust
2004-04-23 16:16   ` Steve Dickson [this message]
2004-04-23 15:08 ` Olaf Kirch
  -- strict thread matches above, loose matches on Subject: below --
2004-04-23 16:16 Lever, Charles
2004-04-23 16:27 ` Steve Dickson
2004-04-23 15:17 Lever, Charles
2004-04-23 14:15 Steve Dickson
2004-04-23 14:33 ` Olaf Kirch
2004-04-23 15:50   ` Steve Dickson
2004-04-23 17:55     ` Olaf Kirch
2004-04-23 18:43       ` Steve Dickson
2004-04-23 18:50         ` Olaf Kirch
2004-04-23 20:07           ` Steve Dickson
2004-04-23 14:36 ` Trond Myklebust
2004-04-23 16:01   ` Steve Dickson
2004-04-23 16:21     ` Trond Myklebust
2004-04-23 17:21       ` Steve Dickson
2004-04-23 17:49         ` Trond Myklebust
2004-04-23 19:14           ` Steve Dickson
     [not found] ` <40892DC0.1010001@redhat.com>
2004-04-23 16:04   ` Steve Dickson
2004-05-01 16:13 ` Steve Dickson
2004-05-01 19:25   ` Trond Myklebust
2004-05-01 23:57     ` Steve Dickson
2004-05-02  0:22       ` Trond Myklebust
2004-05-02  3:19         ` Steve Dickson
2004-05-02  3:28           ` Trond Myklebust
2004-05-03 19:50             ` Steve Dickson
2004-05-03 20:15               ` Trond Myklebust
2004-05-03 20:33                 ` Steve Dickson
2004-05-03 21:27                   ` Trond Myklebust
2004-05-04 19:05                     ` Steve Dickson
2004-05-06 17:39 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4089414B.8090102@RedHat.com \
    --to=steved@redhat.com \
    --cc=Charles.Lever@netapp.com \
    --cc=nfs@lists.sourceforge.net \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox