Linux NFS development
 help / color / mirror / Atom feed
From: Jason Holmes <jholmes@psu.edu>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: mrg <mrg@normailer.com>, nfs@lists.sourceforge.net
Subject: Re: NFS Server problem (kernel > 2.6.5 ?)
Date: Wed, 27 Oct 2004 14:01:55 -0400	[thread overview]
Message-ID: <417FE293.9050204@psu.edu> (raw)
In-Reply-To: <20041027165017.GE4292@fieldses.org>

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

J. Bruce Fields wrote:
> On Wed, Oct 27, 2004 at 06:43:00PM +0200, mrg wrote:
> 
>>Thanks, it worked!
>>
>>I uninstalled the nfs-utils-1.0.6-22 (from FC2), then installed
>>nfs-utils-1.0.6 from kernel.org. Et voila!
> 
> 
> If you download the FC2 srpm you can see the list of patches that
> distinguishes their version from stock nfs-utils-1.0.6.  It might be
> useful to figure out exactly which of those patches it is that causes
> the problem.

For the Enterprise build, it's the "nfs-utils-1.0.6-mountd.patch" patch. 
  I've attached a copy.

Thanks,

--
Jason Holmes


[-- Attachment #2: nfs-utils-1.0.6-mountd.patch --]
[-- Type: text/plain, Size: 2206 bytes --]

#
# Make sure check_new_cache() is looking in the right place
#
--- src/support/nfs/cacheio.c.org	2003-08-04 00:12:16.000000000 -0400
+++ src/support/nfs/cacheio.c	2004-03-22 18:12:55.163534208 -0500
@@ -223,12 +223,23 @@ int readline(int fd, char **buf, int *le
  * This succeeds iff the "nfsd" filesystem is mounted on
  * /proc/fs/nfs
  */
+static char *cachelist[] = {
+	{ "auth.unix.ip" }, { "nfsd.export" }, { "nfsd.fh" }, 
+	{ NULL, NULL }
+};
 int
 check_new_cache(void)
 {
 	struct stat stb;
-	return	(stat("/proc/fs/nfs/filehandle", &stb) == 0) ||
-		(stat("/proc/fs/nfsd/filehandle", &stb) == 0);
+	char path[64];
+	int i;
+
+	for (i=0; cachelist[i]; i++ ){
+		sprintf(path, "/proc/net/rpc/%s/channel", cachelist[i]);
+		if (stat(path, &stb) < 0)
+			return 0;
+	}
+	return 1;
 }	


#
# Eliminate 3 syslog message that are logged for
# successful events.
#
--- src/utils/mountd/mountd.c.org	2003-09-12 18:14:16.000000000 -0400
+++ src/utils/mountd/mountd.c	2004-06-16 09:31:06.000000000 -0400
@@ -90,10 +90,11 @@ mount_dump_1_svc(struct svc_req *rqstp, 
 {
 	struct sockaddr_in *addr =
 		(struct sockaddr_in *) svc_getcaller(rqstp->rq_xprt);
-	xlog(L_NOTICE, "dump request from %s",
-		inet_ntoa(addr->sin_addr));
 
-	*res = mountlist_list();
+	if ((*res = mountlist_list()) == NULL)
+		xlog(L_WARNING, "dump request from %s failed.",
+			inet_ntoa(addr->sin_addr));
+
 	return 1;
 }
 
@@ -143,9 +144,11 @@ mount_export_1_svc(struct svc_req *rqstp
 {
 	struct sockaddr_in *addr =
 		(struct sockaddr_in *) svc_getcaller(rqstp->rq_xprt);
-	xlog(L_NOTICE, "export request from %s",
-		inet_ntoa(addr->sin_addr));
-	*resp = get_exportlist();
+
+	if ((*resp = get_exportlist()) == NULL)
+		xlog(L_WARNING, "export request from %s failed.",
+			inet_ntoa(addr->sin_addr));
+		
 	return 1;
 }
 
@@ -154,9 +157,10 @@ mount_exportall_1_svc(struct svc_req *rq
 {
 	struct sockaddr_in *addr =
 		(struct sockaddr_in *) svc_getcaller(rqstp->rq_xprt);
-	xlog(L_NOTICE, "exportall request from %s",
-		inet_ntoa(addr->sin_addr));
-	*resp = get_exportlist();
+
+	if ((*resp = get_exportlist()) == NULL)
+		xlog(L_WARNING, "exportall request from %s failed.",
+			inet_ntoa(addr->sin_addr));
 	return 1;
 }
 

      reply	other threads:[~2004-10-27 18:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-26  9:22 NFS Server problem (kernel > 2.6.5 ?) mrg
2004-10-26 17:48 ` Jason Holmes
2004-10-26 17:54   ` J. Bruce Fields
2004-10-27 16:43   ` mrg
2004-10-27 16:50     ` J. Bruce Fields
2004-10-27 18:01       ` Jason Holmes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=417FE293.9050204@psu.edu \
    --to=jholmes@psu.edu \
    --cc=bfields@fieldses.org \
    --cc=mrg@normailer.com \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox