Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nfs@lists.sourceforge.net
Subject: Re: [PATCH] -o intr  mount option prevents core dumps on 2.4 kernel
Date: Tue, 11 Jan 2005 14:36:55 -0500	[thread overview]
Message-ID: <41E42AD7.3030303@RedHat.com> (raw)
In-Reply-To: <1105118040.10979.70.camel@lade.trondhjem.org>

Trond Myklebust wrote:

>to den 06.01.2005 Klokka 13:31 (-0500) skreiv Steve Dickson:
>
>  
>
>>Comments... Suggestions... Crimes against humanity that I'm committing???
>>    
>>
>
>
>Firstly, how is "cl_intr" preventing core dumps? Normally, we should be
>masking all signals except SIGKILL, SIGINT and SIGQUIT. I can see that
>masking SIGINT and SIGQUIT might be useful here, but not SIGKILL...
>  
>
Because __rpc_execute() notices that signalled() is set and aborts the 
write by
returning -ERESTARTSYS makes the core dumping code stop dumping.

>Secondly: Why not do all this in rpc_clnt_sigmask()?
>  
>
I looked at that.... but I really was not sure if could hack it up
to turn off signalled() and plus I was sure how I could turn
signalled() back on at the end of the write.... The way I did
just seemed less risky and seem to work...

steved.



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2005-01-11 19:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-06 18:31 [PATCH] -o intr mount option prevents core dumps on 2.4 kernel Steve Dickson
2005-01-07 17:14 ` Trond Myklebust
2005-01-11 19:36   ` Steve Dickson [this message]
2005-01-11 20:10     ` Trond Myklebust
2005-01-11 20:58       ` Steve Dickson
2005-01-11 21:59         ` Trond Myklebust
2005-01-12 18:18           ` Steve Dickson
2005-01-12 18:25             ` Trond Myklebust
2005-01-12 19:11               ` Steve Dickson
2005-01-13  0:38                 ` Trond Myklebust
2005-01-13 14:01                   ` Steve Dickson
2005-01-13 21:37                     ` Steve Dickson
2005-01-14  2:57                       ` Trond Myklebust
2005-01-14 19:52                         ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41E42AD7.3030303@RedHat.com \
    --to=steved@redhat.com \
    --cc=nfs@lists.sourceforge.net \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox