Re: [PATCH] Fix typo on __rpc_purge_upcall

[Vince Busam <vbusam@google.com>]

Trond Myklebust wrote:
> On Mon, 2005-11-21 at 13:51 -0800, Vince Busam wrote:
> 
>>Trond Myklebust wrote:
>>
>>>On Mon, 2005-11-21 at 11:51 -0800, Vince Busam wrote:
>>>
>>>http://client.linux-nfs.org/Linux-2.6.x/2.6.15-rc2/linux-2.6.15-06-rpc_pipe_fix_cleanup.dif
>>>
>>
>>That looks good to me.  After testing this fix for a week, I haven't gotten an Oops, but 
>>the system still locks up.  The only relevant log message is about an upcall timing out.
>>
>>Nov 20 00:19:00 dig kernel: RPC: AUTH_GSS upcall timed out.
>>Nov 20 00:19:00 dig kernel: Please check user daemon is running!
> 
> 
> What kernel is this? There was a patch from Steve that caused this type
> of behaviour in some 2.6.14 CITI_ALL patches. That patch has since been
> removed.

This is 2.6.13.4, with the __rpc_purge_upcall patch, linux-2.6.13-CITI_NFS4_ALL-1.dif, and 
an ugly patch that I don't remember why I'm using.

--- linux-2.6.8/net/sunrpc/auth_gss/auth_gss.c  2004-08-13 22:36:57.000000000 -0700
+++ linux-2.6.8-new/net/sunrpc/auth_gss/auth_gss.c      2004-08-24 14:44:40.887239458 -0700
@@ -515,6 +515,8 @@

         clnt = rpci->private;
         auth = clnt->cl_auth;
+       if (auth == NULL)
+               return;
         gss_auth = container_of(auth, struct gss_auth, rpc_auth);
         spin_lock(&gss_auth->lock);
         while (!list_empty(&gss_auth->upcalls)) {


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs