From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A07EB3161A1; Mon, 3 Aug 2026 16:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785774223; cv=none; b=X9C00IzQ5DVXhnayFKTxsc0Lxlql0NzH0avmPW4lq48r7tCpfVjnIOwkLmlDeHhibqzONVTEbJ4GsZsKWzdDrxfqSH9Nz5RCAQ4HbtiDgi0oyiqxIlc40MItvNJcsj0mZBhqCEGhBeprTtk+4Cs2nvNJnDGTX1UTDYnLkHpcMgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785774223; c=relaxed/simple; bh=XRcwhn5cp517w2ARCusZcReA+p8FgW1DZjb1wXrI8UE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Mqquvx6g94YU99oeVd+HhSDrMJneLPudoUpVHUXHAM+vk59yFI72h9iycKI7HDbB9oTad4IWVOLzfTDYOT64NJbM1y5ggEzT/+dH2UIcTrMJ9DT6XESmuaakf6d8PHCcYKMZ4K0jMWyQQfZV97P7mtOgaCYzpdYstRO3NQAWMEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tq9XV1PV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tq9XV1PV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0DF51F000E9; Mon, 3 Aug 2026 16:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785774222; bh=WuL8bdJtB4VLcz0WbdkREEYKLcbsadv1D1JGn//g5uQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Tq9XV1PVNJZT9GysIEZeLMKNSLeNEdFZzapoCgYsQuAU9HqYaKVvshpJRMm13EEBB YEE1aoa+VlAmps6WZ9QxzNJdP+XcGYR/YqXFxgZ3ekU/3GWQKFRScRMFbu4n29UXhp 1Zlv7ZoZhBhFSgDuQOWsNiU/DQnLlbev4VVKqUxYcmO5Im1P6+WgUtkfUnL4py6E58 U8i06Pg4pvO/o/D3c/IbWwwTHOW+ba7aTN1bigxxO//0gHf9Wfl3b1yVwWF/OwabXD oFZ6CeMMuoBNZHsqE4hZ3NToPIpAlgSYUwEX1GOYfEYhxqpGvDFhF7f7BI7fVH8ni1 IbqMrO95UPmmw== Message-ID: <43a111b0927e4291eb0dfae08def19be1e32e02d.camel@kernel.org> Subject: Re: [PATCH 1/2] nfsd: fix type mismatch and explain host-endian xdr buffer usage From: Jeff Layton To: Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Date: Mon, 03 Aug 2026 12:23:39 -0400 In-Reply-To: References: <20260803-dir-deleg-v1-0-51be76861821@kernel.org> <20260803-dir-deleg-v1-1-51be76861821@kernel.org> <54f8ab19-fb1b-4cd6-9600-e3d3d6971173@app.fastmail.com> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-08-03 at 12:04 -0400, Chuck Lever wrote: >=20 > On Mon, Aug 3, 2026, at 11:43 AM, Jeff Layton wrote: > > On Mon, 2026-08-03 at 11:32 -0400, Chuck Lever wrote: > > >=20 > > > On Mon, Aug 3, 2026, at 10:49 AM, Jeff Layton wrote: > > > > sparse flagged this type mismatch. Also the xdr buffer usage is a b= it > > > > non-standard, so explain what we're doing and why. > > > >=20 > > > > Fixes: 4b64b811f368 ("nfsd: add notification handlers for dir event= s") > > > > Reported-by: kernel test robot > > > > Closes:=20 > > > > https://lore.kernel.org/oe-kbuild-all/202607310455.AT0GoC5j-lkp@int= el.com/ > > > > Signed-off-by: Jeff Layton > > > > --- > > > > fs/nfsd/nfs4xdr.c | 11 ++++++++--- > > > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > >=20 > > > > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > > > > index a47eb544b99f..5cbb4a415384 100644 > > > > --- a/fs/nfsd/nfs4xdr.c > > > > +++ b/fs/nfsd/nfs4xdr.c > > > > @@ -4383,13 +4383,18 @@ nfsd4_setup_notify_entry4(struct notify_ent= ry4=20 > > > > *ne, struct xdr_stream *xdr, > > > > struct path path =3D nf->nf_file->f_path; > > > > struct nfsd4_fattr_args args =3D { }; > > > > const u32 *reqmask; > > > > - uint32_t *attrmask; > > > > + u32 *attrmask; > > > > __be32 status; > > > > bool parent; > > > > int ret; > > > >=20 > > > > - /* Reserve space for attrmask */ > > > > - attrmask =3D xdr_reserve_space(xdr, 3 * sizeof(uint32_t)); > > > > + /* > > > > + * attrmask is the host-order bmval[3] that nfsd4_encode_attr_val= s() > > > > + * consumes and that ne_attrs.attrmask.element points at. It must > > > > + * outlive this call, so steal a few words from the xdr stream to= hold > > > > + * it. > > > > + */ > > > > + attrmask =3D (u32 *)xdr_reserve_space(xdr, 3 * sizeof(*attrmask))= ; > > > > if (!attrmask) > > > > return false; > > >=20 > > > I still don't understand what's going on. "Steal a few words to hold = it" > > > sounds like you're trying to avoid a kmalloc call. Is this code reser= ving > > > space in the XDR stream, or isn't it? If it is, then accessing those = bytes > > > has to be done with a big-endian pointer, the same way it is done at = every > > > other xdr_reserve_space() call site. Storing host-order bytes that ar= e not > > > part of an opaque into an XDR stream is just... wrong. > > >=20 > > > If you're doing the usual "reserve and backfill the encoded data late= r" > > > dance, then spell it the way everyone else does so us poor human read= ers > > > can recognize that's what's going on. > >=20 > > It's using a small piece of the xdr buffer (3 32-bit words) to hold the > > host-endian bitmap fields that will later be encoded into the stream > > when the encoding is actually done. > >=20 > > This piece is not accessed by anything else and there is plenty of room > > in the buffer, so I don't see the issue here. Can you elaborate on why > > you feel that this is a problem? >=20 > Well A-number-1 is that it's a hack and technical debt. It just > isn't obvious what's going on, it needs a four-line comment to > explain it, and it opens the door to people copy-pasting it to > other encoders. >=20 Ok. > Number 2 is that the XDR stream buffer is ephemeral. There are > conditions that callers must stick to to keep that pointer valid > for the lifetime of the xdr_stream. >=20 We only need these allocations to stick around until the encoding is done. They have almost the same lifetime as the xdr buffer itself which is why allocating from it made sense. > Number 3: Yes, we have a sordid history of grabbing a piece of > the xdr_buf's tail iov for temporary storage. That doesn't make > it wise to do, and assumes behavior about that buffer that is > not guaranteed by sunrpc's API contracts. That makes life hard > when future changes need to change that buffer to, say, a page > rather than kmalloc'd memory. Or when I want to convert this > code to use xdrgen instead of hand-rolled encoding. >=20 I had no idea this practice was suddenly forbidden. That has certainly not been communicated to me in any of the previous review rounds over the last couple of years. > So what you've done is fine for operational prototype code, but > not something we can carry forward as production code. The sparse > warning is a canary, it's not the actual structural problem. >=20 Does this mean you intend to drop dir delegation series again? Allocating from the xdr stream in order to hold host-endian fields is done in several places in this code. Reworking that will be a substantial effort. --=20 Jeff Layton