Linux NFS development
 help / color / mirror / Atom feed
From: Chuck Lever <cel@citi.umich.edu>
To: Olaf Kirch <okir@suse.de>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>, nfs@lists.sourceforge.net
Subject: Re: NFS directio
Date: Thu, 30 Mar 2006 12:27:27 -0500	[thread overview]
Message-ID: <442C14FF.3080901@citi.umich.edu> (raw)
In-Reply-To: <1143734612.8093.8.camel@lade.trondhjem.org>

Trond Myklebust wrote:
> On Thu, 2006-03-30 at 17:15 +0200, Olaf Kirch wrote:
>> In recent kernels, NFS direct IO limits the size of a request to
>> 4096 pages, ie 16M on most platforms. This causes growisofs from the
>> dvd+rw-tools package (http://fy.chalmers.se/~appro/linux/DVD+RW/) to fail.
>> Its builtin "dd" style function uses 32M buffers by default.
>>
>> It puzzled me a lot that it is returning -EFBIG, which means "file too
>> big". At least that should be EINVAL, I think. EFBIG should be reserved
>> for problems related to largefile support, IMO.
>>
>> We can easily work around the problem by restricting the buffer size
>> growisofs uses on NFS, but that feels strange. I think the right way
>> would be to increase MAX_DIRECTIO_SIZE, and if someone submits a bigger
>> request, to loop and do that in MAX_DIRECTIO_SIZE chunks.
>>
>> Comments?
> 
> MAX_DIRECTIO_SIZE is gone from Linus' tree. I don't think we have any
> limits on the size of the buffer that users can feed to us apart from
> those set by mm/filemap.c:generic_write_checks().

that's correct.  this was just an arbitrary limit to prevent type 
overflows (namely the atomic_t's were only 24 bits on some platforms).

-- 
corporate:	<cel at netapp dot com>
personal:	<chucklever at bigfoot dot com>


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2006-03-30 17:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-30 15:15 NFS directio Olaf Kirch
2006-03-30 16:03 ` Trond Myklebust
2006-03-30 17:27   ` Chuck Lever [this message]
2006-03-31  7:49   ` Olaf Kirch
2006-03-31 14:35     ` Chuck Lever
2006-03-31 14:58       ` Olaf Kirch
2006-03-31 15:50         ` Chuck Lever
2006-04-09 12:38           ` Neil Brown
2006-04-09 22:09             ` Chuck Lever
2006-04-10  4:20               ` Neil Brown
2006-04-10 10:55                 ` Olaf Kirch
2006-04-10 17:36                 ` Chuck Lever
2006-04-11  0:12                   ` Neil Brown
2006-04-11  0:47                     ` Chuck Lever
2006-04-11  9:15                     ` Olaf Kirch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=442C14FF.3080901@citi.umich.edu \
    --to=cel@citi.umich.edu \
    --cc=nfs@lists.sourceforge.net \
    --cc=okir@suse.de \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox