From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BA254302F2 for ; Mon, 6 Jul 2026 16:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783354564; cv=none; b=RalhHu9i0DssjaP2ZVmcv8YeRzfyCsF9lCaK5RldNPubDZ+77cxCSRYitJs7opmmTNjl+3YCf/oxvpzSD5T5zm59oLXY3IWVuvuJg6w9fsWNmxcLnwlEX9GeVj07AbbN7sJSmKKhXGdLaGoH/agf4Zc6TeRZYo/94U6j3CJpduM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783354564; c=relaxed/simple; bh=Y0iXqWEYk556mXNwb18MzQmwy+TpSVlh9t5pePyyNXw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=JEkhEtrdjsWumKHOlX7wyVB4N9WOyEvNTd4gAipXPh5AnIpB0VYf/Y6qoQ83NmI5AR08k27hMtp2crNHhykSG0K0WRqvCEs+XxmNzBZniCb1076RIsnRdpbgv2g3aPGo4/Gf2eEGtmSCcvEqGxgSQhIpR4iOEQBQ9VBzlTXhs8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HrExwu6o; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HrExwu6o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6951F00A3A; Mon, 6 Jul 2026 16:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783354563; bh=2e3F2tHCfjqQX1Wvi8zausC63YUunJd7q9cOFeFJxts=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=HrExwu6oXGodCLk857/3xwW7SltquwwbhUzNbonDPkvpRt+z86l58RC4NWJ5DI5W1 mCpwy//9npmtwT6nxp1sFHAquv0ub/Rd8iVYZQRv9QIatGAlhZGsJjSDRdI6KNWB7i lk0J9en0gJnTzSl2b3cZbboD9nr8yLrRkHqQmLX0aoUBqPjaZnuKzaJsRWy38AJCW6 09fkbT7y+qVv29syBxN3Ggs0dbQEBo/cBVbLF5rVL/x1afsMR+z69RRSBmF2XjDJUy o35VtmBEJP873cKOtxCLnA7+Go3dchbcOUBrND1MEokudUH6R0zjGj50HUsGMm3a7j rz6ZxmKd38IBQ== Message-ID: <44504a0842d49dbaf5b8ed4d4e4beba0295343b0.camel@kernel.org> Subject: Re: [PATCH v2 04/14] nfsd: move more nfs-specific code into preamble of nfsd4_create_file() From: Jeff Layton To: NeilBrown , Chuck Lever Cc: Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org Date: Mon, 06 Jul 2026 12:16:01 -0400 In-Reply-To: <20260705222032.1240057-5-neilb@ownmail.net> References: <20260705222032.1240057-1-neilb@ownmail.net> <20260705222032.1240057-5-neilb@ownmail.net> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-07-06 at 08:19 +1000, NeilBrown wrote: > From: NeilBrown >=20 > Do NFS-specific prep before interacting with the VFS. >=20 > We now add the verifier to iap early so it applies even when an > EXCLUSIVE4_1 replay is detected based on that verifier, so we will set > those attributes again. This should be harmless even though it will > update ctime and i_version, and so will update the changeid seen by the > client. It shouldn't matter because the resend implies that the client > hasn't seen the file or its changeid. If some other client happens to > have noticed the file, it might see an unnecessary changeid up, but that > is of no consequence. >=20 > Note that ctime would have been updated anyway if the client has > included other attributes like an ACL. >=20 > Signed-off-by: NeilBrown > --- > fs/nfsd/nfs4proc.c | 55 +++++++++++++++++++++++----------------------- > 1 file changed, 27 insertions(+), 28 deletions(-) >=20 > diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c > index 17be4f7420fc..b723ba08ddaf 100644 > --- a/fs/nfsd/nfs4proc.c > +++ b/fs/nfsd/nfs4proc.c > @@ -270,6 +270,9 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc_= fh *fhp, > parent =3D fhp->fh_dentry; > inode =3D d_inode(parent); > =20 > + if (!IS_POSIXACL(inode)) > + iap->ia_mode &=3D ~current_umask(); > + > if (!is_create_with_attrs(open)) { > /* No attrs to check */ > } else if (open->op_acl) { > @@ -289,6 +292,30 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc= _fh *fhp, > open->op_pacl =3D NULL; > } > =20 > + v_mtime =3D 0; > + v_atime =3D 0; > + if (nfsd4_create_is_exclusive(open->op_createmode)) { > + u32 *verifier =3D (u32 *)open->op_verf.data; > + > + /* > + * Solaris 7 gets confused (bugid 4218508) if these have > + * the high bit set, as do xfs filesystems without the > + * "bigtime" feature. So just clear the high bits. If this > + * is ever changed to use different attrs for storing the > + * verifier, then do_open_lookup() will also need to be > + * fixed accordingly. > + */ > + v_mtime =3D verifier[0] & 0x7fffffff; > + v_atime =3D verifier[1] & 0x7fffffff; > + > + iap->ia_valid |=3D ATTR_MTIME | ATTR_ATIME | > + ATTR_MTIME_SET|ATTR_ATIME_SET; > + iap->ia_mtime.tv_sec =3D v_mtime; > + iap->ia_atime.tv_sec =3D v_atime; > + iap->ia_mtime.tv_nsec =3D 0; > + iap->ia_atime.tv_nsec =3D 0; > + } > + > host_err =3D fh_want_write(fhp); > if (host_err) { > status =3D nfserrno(host_err); > @@ -308,23 +335,6 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc= _fh *fhp, > goto out; > } > =20 > - v_mtime =3D 0; > - v_atime =3D 0; > - if (nfsd4_create_is_exclusive(open->op_createmode)) { > - u32 *verifier =3D (u32 *)open->op_verf.data; > - > - /* > - * Solaris 7 gets confused (bugid 4218508) if these have > - * the high bit set, as do xfs filesystems without the > - * "bigtime" feature. So just clear the high bits. If this > - * is ever changed to use different attrs for storing the > - * verifier, then do_open_lookup() will also need to be > - * fixed accordingly. > - */ > - v_mtime =3D verifier[0] & 0x7fffffff; > - v_atime =3D verifier[1] & 0x7fffffff; > - } > - > if (d_really_is_positive(child)) { > /* NFSv4 protocol requires change attributes even though > * no change happened. > @@ -373,9 +383,6 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc_= fh *fhp, > goto out; > } > =20 > - if (!IS_POSIXACL(inode)) > - iap->ia_mode &=3D ~current_umask(); > - > status =3D nfsd4_vfs_create(fhp, &child, open); > if (status !=3D nfs_ok) > goto out; > @@ -389,14 +396,6 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc= _fh *fhp, > /* A newly created file already has a file size of zero. */ > if ((iap->ia_valid & ATTR_SIZE) && (iap->ia_size =3D=3D 0)) > iap->ia_valid &=3D ~ATTR_SIZE; > - if (nfsd4_create_is_exclusive(open->op_createmode)) { > - iap->ia_valid |=3D ATTR_MTIME | ATTR_ATIME | > - ATTR_MTIME_SET|ATTR_ATIME_SET; > - iap->ia_mtime.tv_sec =3D v_mtime; > - iap->ia_atime.tv_sec =3D v_atime; > - iap->ia_mtime.tv_nsec =3D 0; > - iap->ia_atime.tv_nsec =3D 0; > - } > =20 > set_attr: > status =3D nfsd_create_setattr(rqstp, fhp, resfhp, &attrs); Reviewed-by: Jeff Layton