Trond Myklebust wrote: > On Fri, 2007-01-19 at 01:23 +0000, Christoph Hellwig wrote: >> 056-nfs-smp-change_attribute.diff: >> are the barriers really enough? Don't you need at least a lock on >> the writer side? > > The change attribute should always be updated under the inode->lock > anyway. I'm not really sure we need these. What about nfs_end_data_update ?