Linux NFS development
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: nfs@lists.sourceforge.net
Subject: Re: [PATCH] sunrpc: remove dead variable 'rpciod_running'
Date: Fri, 09 Feb 2007 16:03:21 -0800	[thread overview]
Message-ID: <45CD0BC9.2030208@oracle.com> (raw)
In-Reply-To: <20070209200649.GA9686@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

At a glance, this looks reasonable.

Christoph Hellwig wrote:
> rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
> works we don't get a warning for it.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/net/sunrpc/sched.c
> ===================================================================
> --- linux-2.6.orig/net/sunrpc/sched.c	2007-02-06 15:55:43.000000000 +0100
> +++ linux-2.6/net/sunrpc/sched.c	2007-02-06 15:55:45.000000000 +0100
> @@ -973,8 +973,6 @@
>  	spin_unlock(&rpc_sched_lock);
>  }
>  
> -static DECLARE_MUTEX_LOCKED(rpciod_running);
> -
>  static void rpciod_killall(void)
>  {
>  	unsigned long flags;


[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 265 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture Linux Projects Group
email;internet:chuck dot lever at nospam oracle dot com
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2007-02-10  0:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 20:06 [PATCH] sunrpc: remove dead variable 'rpciod_running' Christoph Hellwig
2007-02-10  0:03 ` Chuck Lever [this message]
2007-05-13 15:10 ` Christoph Hellwig
2007-05-13 19:51   ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45CD0BC9.2030208@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=hch@infradead.org \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox