Linux NFS development
 help / color / mirror / Atom feed
From: Peter Staubach <staubach@redhat.com>
To: Neil Brown <neilb@suse.de>
Cc: nfs@lists.sourceforge.net, Steve Dickson <SteveD@redhat.com>
Subject: Re: [PATCH 06/11] nfs-utils: mount:  AUTH_NONE mounts
Date: Tue, 27 Feb 2007 09:13:38 -0500	[thread overview]
Message-ID: <45E43C92.6090805@redhat.com> (raw)
In-Reply-To: <17891.52293.103984.465480@notabene.brown>

Neil Brown wrote:
> On Monday February 26, SteveD@redhat.com wrote:
>   
>> commit 0ffd74c990aca3761b79316d47e1b1778273681c
>> Author: Steve Dickson <steved@redhat.com>
>> Date:   Sat Feb 24 15:27:46 2007 -0500
>>
>>     Added support to specify the AUTH_NONE security flavor (i.e. -o sec=none)
>>     
>
> If you specify "-o sec=none" then data.pseudoflavor will == AUTH_NONE,
> but
>
>   

This support is being added so that the client can mount a file system
which was exported with sec=none.

>>     
>>     Signed-off-by: Steve Dickson <steved@redhat.com>
>>
>> diff --git a/utils/mount/nfsmount.c b/utils/mount/nfsmount.c
>> index d437036..7759260 100644
>> --- a/utils/mount/nfsmount.c
>> +++ b/utils/mount/nfsmount.c
>> @@ -1093,12 +1093,14 @@ nfsmount(const char *spec, const char *node, int *flags,
>>  
>>  		flavor = mountres->auth_flavors.auth_flavors_val;
>>  		while (--i >= 0) {
>> -			if (flavor[i] == data.pseudoflavor)
>> -				yum = 1;
>>  #ifdef NFS_MOUNT_DEBUG
>> -			printf("auth flavor %d: %d\n",
>> -				i, flavor[i]);
>> +			printf("auth flavor[%d] %d\n", i, flavor[i]);
>>  #endif
>> +			if (flavor[i] == data.pseudoflavor ||
>> +				flavor[i] == AUTH_NONE) {
>> +				yum = 1;
>> +				break;
>> +			}
>>     
>
> You are testing if flavor[i] == AUTH_NONE, which doesn't make sense to
> me....

This loop is looking for AUTH_NONE in the list of authentication
flavors that the server supports and was returned through the MOUNT
protocol during mounting.

Basically, if the server file system is exported with AUTH_NONE, then
it doesn't matter what flavor that the client chooses, the server will
always map it to AUTH_NONE and all requests will be processed with the
anonymous uid and gid.

       ps

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2007-02-27 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-26 11:18 [PATCH 06/11] nfs-utils: mount: AUTH_NONE mounts Steve Dickson
2007-02-27  6:14 ` Neil Brown
2007-02-27 14:13   ` Peter Staubach [this message]
2007-02-28 23:08     ` Neil Brown
2007-03-01 16:10       ` Peter Staubach
2007-03-02  4:01         ` Neil Brown
2007-03-02 15:27           ` Peter Staubach
2007-03-13  5:49             ` Neil Brown
2007-03-13 16:13               ` Peter Staubach
2007-03-14 22:47                 ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45E43C92.6090805@redhat.com \
    --to=staubach@redhat.com \
    --cc=SteveD@redhat.com \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox