From: Chuck Lever <chuck.lever@oracle.com>
To: Neil Brown <neilb@suse.de>
Cc: "Talpey, Thomas" <Thomas.Talpey@netapp.com>,
Linux NFS Mailing List <nfs@lists.sourceforge.net>,
Peter Leckie <pleckie@melbourne.sgi.com>,
Greg Banks <gnb@sgi.com>
Subject: Re: [RFC, PATCH 9/15] knfsd: add RDMA debug class to rpc_debug bitfield
Date: Mon, 21 May 2007 10:29:46 -0400 [thread overview]
Message-ID: <4651ACDA.7050207@oracle.com> (raw)
In-Reply-To: <18001.8854.771127.95716@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
Neil Brown wrote:
> On Monday May 21, gnb@sgi.com wrote:
>> In any case I'm happy to do whatever is necessary in the transport
>> patchset, but I'd appreciate Neil's guidance on which approach he'd
>> prefer before I go in with the scalpel. Neil?
>
> I cannot immediately see the value in having different debug bits for
> the socket transport code and the RDMA transport code. The key
> question is "When would you want to see the debugging from one, but
> not from the other", and I cannot see when that would be. Almost
> certainly if you are testing one transport, you will not be using the
> other, so it will not contribute any noise.
That's how I did it in the client transport switch. One bit enables
debug messages for all transports.
> So I suspect we should simply
> #define RPCDBG_FACILITY RPCDBG_SVCSOCK
That's expedient, but I suggest you rename the flag to something less
specific to sockets.
> in any server-RDMA specific files, and see how we go.
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 291 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel/
version:2.1
end:vcard
[-- Attachment #3: Type: text/plain, Size: 286 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
[-- Attachment #4: Type: text/plain, Size: 140 bytes --]
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-05-21 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 17:45 [RFC, PATCH 9/15] knfsd: add RDMA debug class to rpc_debug bitfield Tom Tucker
2007-05-18 18:52 ` Chuck Lever
2007-05-18 18:57 ` Tom Tucker
2007-05-21 3:19 ` Greg Banks
2007-05-21 3:31 ` Tom Tucker
2007-05-21 4:16 ` Greg Banks
2007-05-21 4:39 ` Neil Brown
2007-05-21 14:29 ` Chuck Lever [this message]
2007-05-23 15:14 ` Greg Banks
2007-05-23 20:27 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4651ACDA.7050207@oracle.com \
--to=chuck.lever@oracle.com \
--cc=Thomas.Talpey@netapp.com \
--cc=gnb@sgi.com \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=pleckie@melbourne.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox