Re: [PATCH 15/23] mount.nfs: clean up getport() function

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

J. Bruce Fields wrote:
> On Sat, Jul 28, 2007 at 05:50:24PM -0400, Chuck Lever wrote:
>> Mostly comment clarification.  Also replace some naked undocumented
>> integers with macros, and make getport() static.
>> @@ -153,25 +157,30 @@ unsigned short getport(struct sockaddr_in *saddr, unsigned long prog,
>>  		return 0;
>>  	}
>>  
>> -	switch (prot) {
>> +	switch (proto) {
>>  	case IPPROTO_UDP:
>>  		clnt = clntudp_bufcreate(saddr,
>> -					 PMAPPROG, PMAPVERS, TIMEOUT, &socket,
>> -					 UDPMSGSIZE, UDPMSGSIZE);
>> +					 PMAPPROG, PMAPVERS,
>> +					 RETRY_TIMEOUT, &socket,
>> +					 RPCSMALLMSGSIZE,
>> +					 RPCSMALLMSGSIZE);
>>  		break;
>>  	case IPPROTO_TCP:
>> -		clnt = clnttcp_create(saddr,
>> -			PMAPPROG, PMAPVERS, &socket, 50, 500);
>> +		clnt = clnttcp_create(saddr, PMAPPROG, PMAPVERS, &socket,
>> +				      RPCSMALLMSGSIZE, RPCSMALLMSGSIZE);
> 
> Did you mean to change those final two arguments?  (They were different
> before, then they're the same after.)

They now match the code in support/nfs/conn.c:clnt_ping().

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 290 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs