From: Trond Myklebust <trondmy@kernel.org>
To: Jeff Layton <jlayton@kernel.org>,
Salvatore Bonaccorso <carnil@debian.org>,
Maik Nergert <maik.nergert@uni-hamburg.de>,
Valentin SAMIR <valentin.samir@magellium.fr>,
Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
regressions@lists.linux.dev, 1128834@bugs.debian.org
Subject: Re: [regression] Large rsize/wsize (1MB) causes EIO after 2b092175f5e3 ("NFS: Fix inheritance of the block sizes when automounting")
Date: Sun, 15 Mar 2026 10:12:34 -0400 [thread overview]
Message-ID: <46a87e31656d23d6246d170955ec2d633bfe63ea.camel@kernel.org> (raw)
In-Reply-To: <73c3a6a03fbe30a4f4b05c7fe58b3dceda87c45b.camel@kernel.org>
On Sun, 2026-03-15 at 07:29 -0400, Jeff Layton wrote:
> Servers use the max_request_size to properly size their receive
> buffers, and the client is responsible for adhering to that value. I
> don't think you can stick a bunch of operations in a request compound
> and then put a huge WRITE at the end that blows out max_request_size,
> and expect the server to be OK with that.
>
> ISTM the client should clamp the length down to something shorter
> that
> allows the request to fit. Maybe drop the last folio and force
> another
> request? Performance would suck but it would work.
>
> All that said, the server in this case isn't sizing max_request_size
> with enough overhead for the client to actually achieve a full 1M
> write, which is just dumb. Dell should fix that.
I'm aware of what the spec says, Jeff.
We're not putting "a bunch of operations" before the WRITE. There's a
SEQUENCE, PUTFH, WRITE and GETATTR.
The point is, we expect the value of maxwrite to be set to a reasonable
value w.r.t. max_request_size so that the client doesn't have to sanity
check everybody and their dog's server.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trondmy@kernel.org, trond.myklebust@hammerspace.com
next prev parent reply other threads:[~2026-03-15 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 12:23 [regression] Large rsize/wsize (1MB) causes EIO after 2b092175f5e3 ("NFS: Fix inheritance of the block sizes when automounting") Salvatore Bonaccorso
2026-03-14 15:38 ` Trond Myklebust
2026-03-15 8:37 ` Aurélien Couderc
2026-03-15 11:29 ` Jeff Layton
2026-03-15 14:12 ` Trond Myklebust [this message]
2026-04-04 14:28 ` [PATCH v2 0/1] NFSv4.1: Apply session size limits on clone path Tushar Sariya
2026-04-04 14:28 ` [PATCH v2 1/1] " Tushar Sariya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a87e31656d23d6246d170955ec2d633bfe63ea.camel@kernel.org \
--to=trondmy@kernel.org \
--cc=1128834@bugs.debian.org \
--cc=anna@kernel.org \
--cc=carnil@debian.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=maik.nergert@uni-hamburg.de \
--cc=regressions@lists.linux.dev \
--cc=valentin.samir@magellium.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox