Re: [PATCH] SUNRPC: Fix xdr_decode_string_inplace() mixed sign comparison

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Talpey, Thomas wrote:
> At 01:29 PM 10/31/2007, Chuck Lever wrote:
>> My proposal is to make all the variables in xdr_decode_string_inplace of 
>> type u32, and then work backwards into the ULPs, changing the length 
>> variables of type int to type u32.
> 
> I'd suggest a slight variation - using u32 where the variables shadow
> objects which are decoded/encoded off the wire, but using a native
> type (unsigned int/int) after they are actually passed outside xdr.

Converting XDR types to native types makes sense, I guess.

> For example, the length here is u32 within the xdr routine, but after
> it's decoded, it's really not something we'd want to pass to
> memcpy. IOW, it seems ok to me to have the "maxlen" argument
> remain an int (maybe unsigned), but the internal "len" is naturally u32.

I can't see why we need to handle negative string length values in most 
places, so the length variables should be made unsigned, at least. 
Trond insisted that *lenp and maxlen must be same type here.

However, it seems to me that native string lengths should be size_t. 
(ie the same type that strlen() returns).

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 259 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs