Re: [PATCH] Fix logging segfaults on amd64

[Steve Dickson <SteveD@redhat.com>]

Steinar H. Gunderson wrote:
> Hi,
> 
> It seems an error crept into nfs-utils 1.1.1 just before release, so exportfs
> -r segfaults on amd64 whenever there is a warning. The attached patch, from
> Steve Langasek, fixes the issue (an abuse of va_list).
> 
> Signed-off-by: Steinar H. Gunderson <sesse@debian.org>
> Signed-off-by: Steve Langasek <vorlon@debian.org>
> 
> --- nfs-utils-1.1.1.orig/support/nfs/xlog.c
> +++ nfs-utils-1.1.1/support/nfs/xlog.c
> @@ -133,9 +133,13 @@ xlog_enabled(int fac)
>  void
>  xlog_backend(int kind, const char *fmt, va_list args)
>  {
> +       va_list args2;
> +
>         if (!(kind & (L_ALL)) && !(logging && (kind & logmask)))
>                 return;
> 
> +       va_copy(args2, args);
> +
>         if (log_syslog) {
>                 switch (kind) {
>                 case L_FATAL:
> @@ -172,10 +176,12 @@ xlog_backend(int kind, const char *fmt, 
>                 fprintf(stderr, "%s: ", log_name);
>  #endif
> 
> -               vfprintf(stderr, fmt, args);
> +               vfprintf(stderr, fmt, args2);
How is using args here "an abuse of va_list"? It seem pretty
straightforward to me...

steved.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs