From: Wendy Cheng <wcheng@redhat.com>
To: wcheng@redhat.com
Cc: Neil Brown <neilb@suse.de>, NFS list <linux-nfs@vger.kernel.org>,
cluster-devel@redhat.com
Subject: Re: [PATCH 2/2] Fix lockd panic
Date: Tue, 08 Jan 2008 23:43:22 -0500 [thread overview]
Message-ID: <478450EA.7030608@redhat.com> (raw)
In-Reply-To: <47843957.9060208@redhat.com>
Wendy Cheng wrote:
> Neil Brown wrote:
>
>> Some options:
>>
>> Have an initial patch which removes all references to f_locks and
>> includes the change in this patch. With that in place your main
>> patch won't introduce a bug. If you do this, you should attempt to
>> understand and justify the performance impact (does nlm_traverse_files
>> become quadratic in number of locks. Is that acceptable?).
>>
>> Change the first patch to explicitly update f_count if you bypass the
>> call to nlm_inspect_file.
>>
>> something else???
>>
>>
>
> Let's see what hch says in another email... will come back to this soon.
>
Will do a quick and dirty performance measure tomorrow when I get to the
office. Then we'll go from there.
-- Wendy
next prev parent reply other threads:[~2008-01-09 4:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 5:53 [PATCH 2/2] Fix lockd panic Wendy Cheng
2008-01-08 5:31 ` Neil Brown
[not found] ` <18307.2757.579354.785142-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-01-09 3:02 ` Wendy Cheng
2008-01-09 4:43 ` Wendy Cheng [this message]
2008-01-09 23:33 ` Wendy Cheng
2008-01-12 6:51 ` Wendy Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478450EA.7030608@redhat.com \
--to=wcheng@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox