From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: arnolds-KXqJB1yYWjE05vS0JrMVqf60q2sDzT0c@public.gmane.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mount command: fix config.h includes in util/mount
Date: Tue, 11 Mar 2008 13:13:28 -0400 [thread overview]
Message-ID: <47D6BDB8.6020603@RedHat.com> (raw)
In-Reply-To: <20080311154734.31719.64271.stgit-meopP2rzCrTwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
Chuck Lever wrote:
> Recently #include directives for autoconf's config.h file were added in
> utils/mount/error.c and utils/mount/mount.c, but appropriate HAVE_CONFIG_H
> checks were not added at the same time.
>
> In addition, several other .c files under utils/mount reference
> autoconf-generated HAVE_ macros, but don't appear to include config.h
>
> Also, Heinz-Ado Arnolds <arnolds-KXqJB1yYWjE05vS0JrMVqf60q2sDzT0c@public.gmane.org> reports that this
> patch is needed to ensure START_STATD is properly defined in
> utils/mount/network.c. Otherwise start_statd() is always a no-op, even if
> the configure script defines an appropriate statd start-up script.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> Cc: Heinz-Ado Arnolds <arnolds-KXqJB1yYWjE05vS0JrMVqf60q2sDzT0c@public.gmane.org>
Committed...
steved.
prev parent reply other threads:[~2008-03-11 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 15:47 [PATCH] mount command: fix config.h includes in util/mount Chuck Lever
[not found] ` <20080311154734.31719.64271.stgit-meopP2rzCrTwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-03-11 17:13 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D6BDB8.6020603@RedHat.com \
--to=steved@redhat.com \
--cc=arnolds-KXqJB1yYWjE05vS0JrMVqf60q2sDzT0c@public.gmane.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox