Re: [PATCH] nfs: fix encode_fsinfo_maxsz

[Benny Halevy <bhalevy@panasas.com>]

Trond Myklebust wrote:
> On Thu, 2008-03-13 at 15:26 +0200, Benny Halevy wrote:
>> From: Fred Isaman <iisaman@citi.umich.edu>
>>
>> The previous value was not taking into account space for bitmap array size.
>>
>> Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
>> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
>> ---
>>  fs/nfs/nfs4xdr.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
>> index 51dd380..0277821 100644
>> --- a/fs/nfs/nfs4xdr.c
>> +++ b/fs/nfs/nfs4xdr.c
>> @@ -110,7 +110,7 @@ static int nfs4_stat_to_errno(int);
>>  #define decode_savefh_maxsz     (op_decode_hdr_maxsz)
>>  #define encode_restorefh_maxsz  (op_encode_hdr_maxsz)
>>  #define decode_restorefh_maxsz  (op_decode_hdr_maxsz)
>> -#define encode_fsinfo_maxsz	(op_encode_hdr_maxsz + 2)
>> +#define encode_fsinfo_maxsz	(encode_getattr_maxsz)
>>  #define decode_fsinfo_maxsz	(op_decode_hdr_maxsz + 11)
>>  #define encode_renew_maxsz	(op_encode_hdr_maxsz + 3)
>>  #define decode_renew_maxsz	(op_decode_hdr_maxsz)
> 
> Thanks!
> 
> Has this ever been observed to cause problems in the mainline NFSv4?
> Having never seen any such problems myself, I'm a bit inclined to delay
> this until the 2.6.26 merge window. That said, if you can point to an
> instance where it caused a bug, then I'll push it to Linus sooner.

I can't point to such an instance.
I *think* it was found by code inspection only.
Maybe Fred can...

Benny

> 
> Cheers
>   Trond
>