Trond Myklebust wrote:
> Hi Peter,
>
> The following patchsets takes up the theme from the NLM patch that you
> sent me a couple of weeks ago, and re-implements your fix in terms
> that are closer to the existing NFSv4 implementation (which you
> said was fine).

Hi, Trond.

Thanx for doing this!  I started recoding and got some stuff
working, but then got distracted by higher priority issues.

I wasn't pleased with the look and feel of the stuff that I
had developed, so I was waiting to finish it up.

Your patch is a bit more extensive than mine, which is good.

However, I think that nlmclnt_unlock() needs to wait until
the RPC is completed.  The original problem was test12() in
the Connectathon testsuite, which would occasionally fail.
It would fail because the parent would kill the child process
(actually the child of the child) and immediately attempt to
grab the lock.  This would fail because the child hadn't
completed releasing the lock yet.  There were some timing
dependencies in test12() itself, which I eliminated, but then
discovered that this wouldn't solve the entire problem.  (I
can send you the new version of test12(), if you wish.)

I think that it was this need to wait in nlmclnt_unlock()
which made the patch less pleasing than I wanted.  I have
attached the current version that I had worked on, just
for grins.

    Thanx...

       ps