From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH] NFS Client mounts hang when exported directory do not exist Date: Fri, 11 Apr 2008 12:10:18 -0400 Message-ID: <47FF8D6A.9040902@RedHat.com> References: <47FF7FCC.2050403@RedHat.com> <1207927210.3379.1.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Fedora Kernel Mailing list , Linux NFS Mailing list To: Eric Paris Return-path: In-Reply-To: <1207927210.3379.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedora-kernel-list-bounces@redhat.com Errors-To: fedora-kernel-list-bounces@redhat.com List-ID: Eric Paris wrote: > On Fri, 2008-04-11 at 11:12 -0400, Steve Dickson wrote: >> This patch fixes a regression that was introduced by the string based mounts. >> >> nfs_mount() statically returns -EACCES for every error returned >> by the remote mounted. This is incorrect because -EACCES is >> an non-fatal error to the mount.nfs command. This error causes >> mount.nfs to retry the mount even in the case when the exported >> directory does not exist. >> >> This patch maps the errors returned by the remote mountd into >> valid errno values, exactly how it was done pre-string based >> mounts. By returning the correct errno enables mount.nfs >> to do the right thing. > > Does this mean the EACCES can/will again become fatal in mount.nfs like > it used to be? EACCES is still a non-fatal error as it was... The problem is the kernel was should have been returning ENOENT, which is a fatal error, instead of EACCES. steved.