Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: chuck.lever@oracle.com
Cc: Fedora Kernel Mailing list <fedora-kernel-list@redhat.com>,
	Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS Client mounts hang when exported directory do not exist
Date: Fri, 11 Apr 2008 12:37:23 -0400	[thread overview]
Message-ID: <47FF93C3.8040109@RedHat.com> (raw)
In-Reply-To: <47FF902C.40301@oracle.com>

Chuck Lever wrote:
> Steve Dickson wrote:
>> This patch fixes a regression that was introduced by the string based
>> mounts.
>> nfs_mount() statically returns -EACCES for every error returned
>> by the remote mounted. This is incorrect because -EACCES is
>> an non-fatal error to the mount.nfs command. This error causes
>> mount.nfs to retry the mount even in the case when the exported
>> directory does not exist. 
> 
> I don't doubt this is the case, but I'd like to see a few real world
> examples (maybe even add them as documentary comments in mount.nfs or in
> the kernel).
Thats easy.. Do a Fedora install over NFS and mistype the mount
point. Instead of returning immediately like it should, one has to
wait 2mins for the error.. 

ENOENT during a mount has always been a fatal error as it should be
and this patch is just restoring that fact.

steved.

  reply	other threads:[~2008-04-11 16:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11 15:12 [PATCH] NFS Client mounts hang when exported directory do not exist Steve Dickson
     [not found] ` <47FF7FCC.2050403-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-04-11 15:20   ` Eric Paris
     [not found]     ` <1207927210.3379.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-04-11 16:10       ` Steve Dickson
     [not found]         ` <47FF8D6A.9040902-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-04-11 18:35           ` Eric Paris
     [not found]             ` <1207938902.3379.7.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-04-12  0:14               ` Steve Dickson
2008-04-11 16:22   ` Chuck Lever
2008-04-11 16:37     ` Steve Dickson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-11 16:05 Steve Dickson
2008-04-12  0:03 Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FF93C3.8040109@RedHat.com \
    --to=steved@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=fedora-kernel-list@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox