From: Peter Staubach <staubach@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Jeff Layton <jlayton@redhat.com>,
linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH] NFS: implement option checking when remounting NFS filesystems
Date: Fri, 11 Apr 2008 16:14:38 -0400 [thread overview]
Message-ID: <47FFC6AE.8080609@redhat.com> (raw)
In-Reply-To: <1207942347.14621.1.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
Trond Myklebust wrote:
> On Fri, 2008-04-11 at 15:19 -0400, Peter Staubach wrote:
>
>> Jeff Layton wrote:
>>
>>> When remounting an NFS or NFS4 filesystem, the new NFS options are not
>>> respected, yet the remount will still return success. This patch adds
>>> a remount_fs sb op for NFS that checks any new nfs mount options against
>>> the existing ones and fails the mount if any have changed.
>>>
>>> This is only implemented for string-based mount options since doing
>>> this with binary options isn't really feasible.
>>>
>> What about respecting the new options as makes sense and rejecting
>> those which absolutely can't be changed dynamically?
>>
>
> If we were to do this, then how should superblocks that are shared
> between multiple mountpoints behave?
Do you mean if those other mountpoints were mounted with explicit
options and this remount might affect those options?
Isn't the same problem that we potentially have today?
Thanx...
ps
next prev parent reply other threads:[~2008-04-11 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 18:10 [PATCH] NFS: implement option checking when remounting NFS filesystems Jeff Layton
2008-04-11 19:01 ` Chuck Lever
2008-04-11 19:05 ` Jeff Layton
2008-04-11 19:19 ` Peter Staubach
2008-04-11 19:32 ` Trond Myklebust
2008-04-11 19:47 ` Jeff Layton
[not found] ` <1207942347.14621.1.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-04-11 20:14 ` Peter Staubach [this message]
2008-04-11 21:07 ` Trond Myklebust
2008-04-11 21:20 ` Peter Staubach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FFC6AE.8080609@redhat.com \
--to=staubach@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox