linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <steved@redhat.com>
To: libtirpc <libtirpc-devel@lists.sourceforge.net>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: -Wold-style-definition warnings
Date: Fri, 15 Aug 2025 12:23:14 -0400	[thread overview]
Message-ID: <482e394f-67bc-48bf-88e4-3808f508737e@redhat.com> (raw)

Hello,

On the more recent gcc version (15.1.1) the
-Wold-style-definition flag is set by default.

This causes
     warning: old-style function definition [-Wold-style-definition]

warnings when functions are defined like

int add(a, b)
int a;
int b;
{}

instead of like this

int add(int a, int b)
{}

Now I did fix these warnings in the latest rpcbind
release... But libtirpc is a different story.

I would have to change almost every single function
in the library to remove these warnings or add I
could add -Wno-old-style-definition to the CFLAGS.

Now I'm more that willing to do the work... Heck
I'm halfway through... But does it make sense to
change the foot print of every function for a
warning that may not make any sense?

Thoughts...

tia,

steved.


             reply	other threads:[~2025-08-15 16:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15 16:23 Steve Dickson [this message]
2025-08-15 17:26 ` -Wold-style-definition warnings Chuck Lever
2025-08-15 18:07   ` Steve Dickson
2025-08-15 18:18     ` Chuck Lever
2025-08-15 18:32       ` Steve Dickson
2025-08-18  0:50       ` [Libtirpc-devel] " Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482e394f-67bc-48bf-88e4-3808f508737e@redhat.com \
    --to=steved@redhat.com \
    --cc=libtirpc-devel@lists.sourceforge.net \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).