From: "Steve French (smfltc)" <smfltc@us.ibm.com>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Matthew Dharm
<mdharm-usb-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org>,
Christoph Hellwig <hch@infradead.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Adrian Bunk <bunk@kernel.org>,
USB Storage list
<usb-storage-ijkIwGHArpdIPJnuZ7Njw4oP9KaGy4wf@public.gmane.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
"David S. Miller"
<davem-xgOahHnHvIuGfricDzPwBeTW4wlIGRCZ@public.gmane.org>,
systemtap-R2MHTz/CkKAf7BdofF/totBPR1lH4CV8@public.gmane.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-cifs-client@lists.samba.org, linux-nfs@vger.kernel.org
Subject: Re: Re: [PATCH] usb-storage: don't call utsname()
Date: Wed, 21 May 2008 13:19:32 -0500 [thread overview]
Message-ID: <483467B4.1060601@us.ibm.com> (raw)
In-Reply-To: <20080521180957.GA17598@kroah.com>
Greg KH wrote:
> On Wed, May 21, 2008 at 01:51:17PM -0400, Alan Stern wrote:
>
>> This patch (as1100) replaces the core-kernel function call to utsname()
>> in usb-storage with the UTS_RELEASE macro. It's used only for warning
>> about extra unusual_devs entries.
>>
>> Signed-off-by: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
>>
>
> Why? With this change, if you change the version number, the file will
> have to be rebuilt. Without the change, the file will not need to be
> rebuilt, right?
>
> I thought that was why this change was made a while ago, to prevent
> things from having to be rebuilt that didn't need to be
>
I agree - what was wrong with utsname->release ... it seems odd to
statically build the kernel's version
number into a module - it should be something we should be able to query
(and it shouldn't change without
reboot so accessing it is not racy). Access to other fields in the
structure (nodename, domainname etc.) might
need to be included in a macro but I didn't see one in utsname.h for this.
next prev parent reply other threads:[~2008-05-21 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080505182937.GZ17139@cs181133002.pp.htv.fi>
[not found] ` <y0mwsloq4kc.fsf@ton.toronto.redhat.com>
[not found] ` <20080520172730.GA2361@infradead.org>
[not found] ` <20080520183802.GA686@redhat.com>
2008-05-21 12:37 ` [2.6 patch] unexport uts_sem Christoph Hellwig
2008-05-21 17:51 ` [PATCH] usb-storage: don't call utsname() Alan Stern
[not found] ` <Pine.LNX.4.44L0.0805211349480.3409-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2008-05-21 18:09 ` Greg KH
2008-05-21 18:19 ` Steve French (smfltc) [this message]
2008-05-21 18:52 ` Christoph Hellwig
2008-05-21 19:35 ` Greg KH
2008-05-21 21:01 ` Steve French (smfltc)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483467B4.1060601@us.ibm.com \
--to=smfltc@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=davem-xgOahHnHvIuGfricDzPwBeTW4wlIGRCZ@public.gmane.org \
--cc=fche@redhat.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mdharm-usb-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=systemtap-R2MHTz/CkKAf7BdofF/totBPR1lH4CV8@public.gmane.org \
--cc=usb-storage-ijkIwGHArpdIPJnuZ7Njw4oP9KaGy4wf@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox