Re: [2.6 patch] uninline nfsd4_op_name()

J. Bruce Fields
2008-08-11T15:39:34Z

On Mon, Aug 11, 2008 at 11:47:44AM +0300, Benny Halevy wrote:
> On Aug. 11, 2008, 6:03 +0300, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> > On Sun, Aug 10, 2008 at 02:32:31PM +0300, Benny Halevy wrote:
> >> Linus Torvalds wrote:
> >>> On Fri, 8 Aug 2008, Adrian Bunk wrote:
> >>>> There doesn't seem to be a compelling reason why nfsd4_op_name() is
> >>>> marked as "inline":
> >> Agreed.
> >>
> >>> It should also return a "const char *", I think.
> >>>
> >>> Since it does.
> >> Right.
> >
> > OK, I modified that to add "const" as Linus suggests, and applied to
> >
> > git://linux-nfs.org/~bfields/linux.git for-2.6.27
> >
> > Thanks to everyone.
> >
> > --b.
>
> Bruce, Linus already corrected and merged Adrian's patch in
> linux-2.6/master as commit f1c7f79b6ab4f7ada002a0fae47f462ede6b6857

Oops, I thought I'd checked for that, but somehow I overlooked that
commit. Thanks.--b.