From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH 0/3] AF_INET6 support for probe_bothports() Date: Mon, 08 Dec 2008 08:46:36 -0500 Message-ID: <493D253C.2040809@RedHat.com> References: <20081202175403.5206.91389.stgit@ingres.1015granger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45914 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752089AbYLHNsx (ORCPT ); Mon, 8 Dec 2008 08:48:53 -0500 In-Reply-To: <20081202175403.5206.91389.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: Chuck Lever wrote: > Hi Steve- > > Here's the next step. > > This small series of patches rewires probe_bothports() to support > AF_INET6 addresses, now that the underlying functions can handle them. > > Since legacy code in other parts of the mount command still use > probe_bothports() and the clnt_addr_t data type, I've added a new > function call to do the IPv6 duties. The old API still exists and > continues to support only AF_INET, but under the covers it calls the > new code. > > Again, for the time being, this is used only for the legacy binary > mount(2) interface. We will need this for umount later, and that is > used to support both binary and text-based mounts. > > --- > > Chuck Lever (3): > mount command: AF_INET6 support for probe_bothports() > mount command: support AF_INET6 in probe_nfsport() and probe_mntport() > mount command: full support for AF_INET6 addresses in probe_port() > Question: in the clnt_addr_t typedef: typedef struct { char **hostname; struct sockaddr_in saddr; struct pmap pmap; } clnt_addr_t; Why isn't saddr a struct sockaddr instead of a struct sockaddr_in? It seems at the beginning of each routine saddr is always being typecast into a struct sockaddr pointer.... So wouldn't be easier and cleaner to simply make sadd a struct sockaddr or am I missing something? steved.