From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH 0/3] nfs-utils: Enabling TCP wrappers Date: Thu, 18 Dec 2008 15:49:18 -0500 Message-ID: <494AB74E.3040403@RedHat.com> References: <49468BC7.2000907@RedHat.com> <1819C671-5353-45B4-A814-98B1B2A4BEB1@oracle.com> <494AABA1.4070006@RedHat.com> <04AA0955-045D-432B-B96D-4A21F4889F6D@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Olaf Kirch , Linux NFS Mailing List To: Chuck Lever Return-path: Received: from mx2.redhat.com ([66.187.237.31]:57686 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbYLRUxe (ORCPT ); Thu, 18 Dec 2008 15:53:34 -0500 In-Reply-To: <04AA0955-045D-432B-B96D-4A21F4889F6D@oracle.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: Chuck Lever wrote: >> @@ -72,12 +74,29 @@ mount_dispatch(struct svc_req *rqstp, SVCXPRT >> *transp) >> union mountd_results result; >> >> #ifdef HAVE_TCP_WRAPPER >> +#ifdef IPV6_SUPPORTED >> + static int once = 0; >> + >> + if (svc_getcaller(transp)->sin_family != AF_INET) { > > It's not clear to me that svc_getcaller() will ever return a non-AF_INET > address. > > Should we use svc_getcaller_netbuf() here instead? I would if I could but there is no svc_getcaller_netbuf() in the glibc version of RPC... steved.