Re: [PATCH 02/47] sunrpc: add cl_private field to struct rpc_clnt

[Benny Halevy <bhalevy@panasas.com>]

On Mar. 28, 2009, 3:39 +0300, "Myklebust, Trond" <Trond.Myklebust@netapp.com> wrote:
> On Mar 27, 2009, at 8:06 PM, "J. Bruce Fields" <bfields@fieldses.org>  
> wrote:
> 
>> On Fri, Mar 27, 2009 at 06:01:48AM +0300, Benny Halevy wrote:
>>> From: Andy Adamson <andros@netapp.com>
>>>
>>> Note: the NFSv4.1 client also uses (and declares) this pointer.
>> OK.  Ack from trond?
> 
> 
> First, someone would need to remind me why it is necessary, and add  
> that justification to the changelog.

First time this is used in this patchset is here:
[PATCH 35/47] nfsd: minorversion support for the back channel

The client uses cl_private to determine the minorversion
(via a struct nfs_client *) to be set in the compound header,
and to know when to generate a SEQUENCE op.
Similarly, the server puts a struct nfs4_callback * in
there for callback compounds' CB_COMPOUND and CB_SEQUENCE.

Benny

> 
>      Trond
>>
>> --b.
>>
>>> Signed-off-by: Andy Adamson <andros@netapp.com>
>>> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
>>> ---
>>> include/linux/sunrpc/clnt.h |    1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/include/linux/sunrpc/clnt.h b/include/linux/sunrpc/ 
>>> clnt.h
>>> index c39a210..928c547 100644
>>> --- a/include/linux/sunrpc/clnt.h
>>> +++ b/include/linux/sunrpc/clnt.h
>>> @@ -53,6 +53,7 @@ struct rpc_clnt {
>>>    char            cl_pathname[30];/* Path in rpc_pipe_fs */
>>>    struct vfsmount *    cl_vfsmnt;
>>>    struct dentry *        cl_dentry;    /* inode */
>>> +    void            *cl_private;    /* private data */
>>>    struct rpc_clnt *    cl_parent;    /* Points to parent of clones  
>>> */
>>>    struct rpc_rtt        cl_rtt_default;
>>>    struct rpc_timeout    cl_timeout_default;
>>> -- 
>>> 1.6.2.1
>>>