Re: [pnfs] [PATCH 20/22] SQUASHME nfsd41 nfsd4_is_solo_sequence

[Benny Halevy <bhalevy@panasas.com>]

On Apr. 03, 2009, 3:20 +0300, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
> 
> March 31 review comments.
> squash into nfsd41: non-page DRC for solo sequence responses
> 
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
>  include/linux/nfsd/xdr4.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/nfsd/xdr4.h b/include/linux/nfsd/xdr4.h
> index 018a821..0352863 100644
> --- a/include/linux/nfsd/xdr4.h
> +++ b/include/linux/nfsd/xdr4.h
> @@ -487,10 +487,10 @@ struct nfsd4_compoundres {
>  	struct nfsd4_compound_state	cstate;
>  };
>  
> -static inline u32 nfsd4_is_solo_sequence(struct nfsd4_compoundres *resp)
> +static inline int nfsd4_is_solo_sequence(struct nfsd4_compoundres *resp)

returning bool would be best.

Benny

>  {
>  	struct nfsd4_compoundargs *args = resp->rqstp->rq_argp;
> -	return args->opcnt == 1 ? 1 : 0;
> +	return args->opcnt == 1;
>  }
>  
>  static inline u32 nfsd4_not_cached(struct nfsd4_compoundres *resp)