From: Kevin Constantine <Kevin.Constantine-FfNkGbSheRGpB8w63BLUukEOCMrvLtNR@public.gmane.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] nfsstat.c: Print diff stats every N seconds
Date: Fri, 03 Apr 2009 10:10:15 -0700 [thread overview]
Message-ID: <49D642F7.3040900@disney.com> (raw)
In-Reply-To: <49D62A92.5090907-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
Steve Dickson wrote:
> Hey Kevin,
>
> I apologize for taking so long to look at this... but...
>
> Question: I notice that the v3 stats are displayed one
> way (in list format) and the v4 stats are display in
> another way (in column format) was this on purpose?
> Should they be displayed using the same format?
>
Steve-
I re-worked, and re-submitted the patches per some suggestions from
Greg. I've since found an output bug that if --sleep=1 outputs a
newline when there's no nfs traffic. It'd probably just be easiest if I
re-send the patches at this point if that works for you.
-kevin
> steved.
>
> Kevin Constantine wrote:
>> nfsstat.c: Implemented --sleep[interval] option.
>> nfsstat.man: Added information about the --sleep option
>> Signed-off-by: Kevin Constantine <kevin.constantine-FfNkGbSheRGpB8w63BLUukEOCMrvLtNR@public.gmane.org>
>> ---
>> utils/nfsstat/nfsstat.c | 158 +++++++++++++++++++++++++++++++++++++--------
>> utils/nfsstat/nfsstat.man | 6 ++-
>> 2 files changed, 137 insertions(+), 27 deletions(-)
>>
>> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
>> index 1517414..c25580c 100644
>> --- a/utils/nfsstat/nfsstat.c
>> +++ b/utils/nfsstat/nfsstat.c
>> @@ -167,10 +167,16 @@ DECLARE_SRV(srvinfo, _old);
next prev parent reply other threads:[~2009-04-03 17:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 17:45 [PATCH 1/2] nfsstat.c: Print diff stats every N seconds Kevin Constantine
[not found] ` <1237225556-27691-1-git-send-email-kevin.constantine-FfNkGbSheRGpB8w63BLUukEOCMrvLtNR@public.gmane.org>
2009-03-16 17:45 ` [PATCH 2/2] nfsstat: Add --list flag Kevin Constantine
[not found] ` <1237225556-27691-2-git-send-email-kevin.constantine-FfNkGbSheRGpB8w63BLUukEOCMrvLtNR@public.gmane.org>
2009-03-17 4:18 ` Greg Banks
2009-03-17 7:46 ` [PATCH 1/2] nfsstat: Print diff stats every N seconds Kevin Constantine
[not found] ` <1237275989-16421-1-git-send-email-kevin.constantine-FfNkGbSheRGpB8w63BLUukEOCMrvLtNR@public.gmane.org>
2009-03-17 7:46 ` [PATCH 2/2] nfsstat: Add --list flag Kevin Constantine
[not found] ` <1237275989-16421-2-git-send-email-kevin.constantine-FfNkGbSheRGpB8w63BLUukEOCMrvLtNR@public.gmane.org>
2009-03-18 2:43 ` Greg Banks
2009-03-18 2:43 ` [PATCH 1/2] nfsstat: Print diff stats every N seconds Greg Banks
2009-03-17 12:15 ` [PATCH 2/2] nfsstat: Add --list flag Steve Dickson
[not found] ` <49BF9460.4050108-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-03-17 16:16 ` Frank Filz
2009-03-17 16:33 ` Kevin Constantine
2009-03-17 4:03 ` [PATCH 1/2] nfsstat.c: Print diff stats every N seconds Greg Banks
2009-04-03 15:26 ` Steve Dickson
[not found] ` <49D62A92.5090907-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-04-03 17:10 ` Kevin Constantine [this message]
[not found] ` <49D642F7.3040900-P5ys19MLBK/QT0dZR+AlfA@public.gmane.org>
2009-04-03 18:20 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D642F7.3040900@disney.com \
--to=kevin.constantine-ffnkgbshergpb8w63bluukeocmrvltnr@public.gmane.org \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox