Re: [PATCH] mountd: use separate lockfiles

[Steve Dickson <SteveD@redhat.com>]

Ben Myers wrote:
> Hey Trond,
> 
> On Thu, Mar 19, 2009 at 02:53:57PM -0500, Ben Myers wrote:
>> On Thu, Mar 19, 2009 at 02:01:21PM -0400, Trond Myklebust wrote:
>>> Why do you need a second call to open() in the first place?
>> I'll give it another try.
> 
> Here it is again.  It works just fine without the second open.
> 
> Thanks,
> 	Ben
> 
> 
> From 1687f7a02cd34f76d5e6c461ca7d7bb56f3826d6 Mon Sep 17 00:00:00 2001
> From: Ben Myers <bpm@sgi.com>
> Date: Thu, 19 Mar 2009 16:44:54 -0500
> Subject: [PATCH] Mountd should use separate lockfiles
> 
> Mountd keeps file descriptors used for locks separate from those used for io
> and seems to assume that the lock will only be released on close of the file
> descriptor that was used with fcntl.  Actually the lock is released when any
> file descriptor for that file is closed.  When setexportent() is called after
> xflock() he closes and reopens the io file descriptor and defeats the lock.
> 
> This patch fixes that by using a separate file for locking, cleaning them up
> when finished.
> 
> Signed-off-by: Ben Myers <bpm@sgi.com>
Committed...

steved.