linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs-utils: reverse order of librpcsecgss and libgssglue checks
Date: Wed, 15 Apr 2009 13:59:11 -0400	[thread overview]
Message-ID: <49E6206F.8010409@RedHat.com> (raw)
In-Reply-To: <20090406155735.6991.31157.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>



Chuck Lever wrote:
> The check that validates the version of librpcsecgss also needs to
> have libgssglue installed.  Without libgssglue, ./configure complains
> that it can't find rpcsecgss, even though it's installed.
> 
> It also turns out that the error message generated by pkg-config is
> more complete than the one we have in aclocal/rpcsec_vers.m4, so just
> let those PKG_CHECK_MODULES m4 macros use the default error message.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
> Hi Steve-
> 
> One more minor bugfix for configure.ac....
> 
>  aclocal/rpcsec_vers.m4 |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/aclocal/rpcsec_vers.m4 b/aclocal/rpcsec_vers.m4
> index e59c0aa..25902ca 100644
> --- a/aclocal/rpcsec_vers.m4
> +++ b/aclocal/rpcsec_vers.m4
> @@ -1,12 +1,11 @@
>  dnl Checks librpcsec version
>  AC_DEFUN([AC_RPCSEC_VERSION], [
>  
> -  dnl TI-RPC replaces librpcsecgss, but we still need libgssglue
> +  PKG_CHECK_MODULES([GSSGLUE], [libgssglue >= 0.1])
> +
> +  dnl TI-RPC replaces librpcsecgss
>    if test "$enable_tirpc" = no; then
> -    PKG_CHECK_MODULES([RPCSECGSS], [librpcsecgss >= 0.16], ,
> -                      [AC_MSG_ERROR([Unable to locate information required to use librpcsecgss.  If you have pkgconfig installed, you might try setting environment variable PKG_CONFIG_PATH to /usr/local/lib/pkgconfig])])
> -  else
> -    PKG_CHECK_MODULES([GSSGLUE], [libgssglue >= 0.1])
> +    PKG_CHECK_MODULES([RPCSECGSS], [librpcsecgss >= 0.16])
>    fi
>  
>  ])dnl
> 
Committed...

steved.

      parent reply	other threads:[~2009-04-15 18:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 15:58 [PATCH] nfs-utils: reverse order of librpcsecgss and libgssglue checks Chuck Lever
     [not found] ` <20090406155735.6991.31157.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2009-04-15 17:59   ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E6206F.8010409@RedHat.com \
    --to=steved@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).