From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH] nfs-utils: reverse order of librpcsecgss and libgssglue checks Date: Wed, 15 Apr 2009 13:59:11 -0400 Message-ID: <49E6206F.8010409@RedHat.com> References: <20090406155735.6991.31157.stgit@ingres.1015granger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38447 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbZDOSCG (ORCPT ); Wed, 15 Apr 2009 14:02:06 -0400 In-Reply-To: <20090406155735.6991.31157.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: Chuck Lever wrote: > The check that validates the version of librpcsecgss also needs to > have libgssglue installed. Without libgssglue, ./configure complains > that it can't find rpcsecgss, even though it's installed. > > It also turns out that the error message generated by pkg-config is > more complete than the one we have in aclocal/rpcsec_vers.m4, so just > let those PKG_CHECK_MODULES m4 macros use the default error message. > > Signed-off-by: Chuck Lever > --- > > Hi Steve- > > One more minor bugfix for configure.ac.... > > aclocal/rpcsec_vers.m4 | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/aclocal/rpcsec_vers.m4 b/aclocal/rpcsec_vers.m4 > index e59c0aa..25902ca 100644 > --- a/aclocal/rpcsec_vers.m4 > +++ b/aclocal/rpcsec_vers.m4 > @@ -1,12 +1,11 @@ > dnl Checks librpcsec version > AC_DEFUN([AC_RPCSEC_VERSION], [ > > - dnl TI-RPC replaces librpcsecgss, but we still need libgssglue > + PKG_CHECK_MODULES([GSSGLUE], [libgssglue >= 0.1]) > + > + dnl TI-RPC replaces librpcsecgss > if test "$enable_tirpc" = no; then > - PKG_CHECK_MODULES([RPCSECGSS], [librpcsecgss >= 0.16], , > - [AC_MSG_ERROR([Unable to locate information required to use librpcsecgss. If you have pkgconfig installed, you might try setting environment variable PKG_CONFIG_PATH to /usr/local/lib/pkgconfig])]) > - else > - PKG_CHECK_MODULES([GSSGLUE], [libgssglue >= 0.1]) > + PKG_CHECK_MODULES([RPCSECGSS], [librpcsecgss >= 0.16]) > fi > > ])dnl > Committed... steved.