From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [RFC 0/4] nfs-utils: nfsd support for minor version Date: Thu, 16 Apr 2009 14:13:16 -0400 Message-ID: <49E7753C.4010300@RedHat.com> References: <49E2F6E4.2080501@panasas.com> <49E769C5.6010902@RedHat.com> <49E7721E.2070601@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: NFS list , pNFS Mailing List , "J. Bruce Fields" To: Benny Halevy Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55210 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753132AbZDPSQJ (ORCPT ); Thu, 16 Apr 2009 14:16:09 -0400 In-Reply-To: <49E7721E.2070601@panasas.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: Benny Halevy wrote: >> Benny Halevy wrote: >>> Steve, please review the following patch that add support >>> for controlling the nfsv4 minor version support via >>> /proc/fs/nfsd/versions. >>> >>> [PATCH 1/4] utils/nfsd: fix -N optarg error printout >>> This patch fixes an existing bug. >> This is a bug... and has been committed... >> >>> [RFC 2/4] utils/nfsd: add support for minorvers4 >>> Under-the-cover support for minorvers4 >> I see you let minorvers4 default to zero, which means 4.1 >> support is off by default. Why? As long as we have away to >> turn of 4.1 processing (i.e. your 4/4 patch), then I see >> no reason we should have the support enabled by default. > > I was also thinking about using the new nfs-utils with old kernels. > Though, these should not puke on seeing [-+]4.1, they'll > just interpret it as enabling/disabling v4. > I'll test that... I just did... Using the '-N 4.1' flag to rpc.nfsd on an older kernel simply turns off all v4 processing... which is fine, IMHO... steved.