RE: [RFC 04/10] nfsd41: Remember the auth flavor to use forcallbacks

Labiaga, Ricardo
2009-05-05T02:52:08Z

> -----Original Message-----
> From: J. Bruce Fields [mailto:bfields@fieldses.org]
> Sent: Sunday, May 03, 2009 1:43 PM
> To: Benny Halevy
> Cc: Labiaga, Ricardo; pnfs@linux-nfs.org; linux-nfs@vger.kernel.org
> Subject: Re: [RFC 04/10] nfsd41: Remember the auth flavor to use
> forcallbacks
>
> On Fri, May 01, 2009 at 02:06:01AM +0300, Benny Halevy wrote:
> > From: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
> >
> > The callbacks will be sent using the same authentication flavor that
> > was used during session creation. We'll add code to remember the
> > principal in the case RPCSEC_GSS in a separate patch.
> >
> > Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
> > Signed-off-by: Benny Halevy <bhalevy@panasas.com>
> > ---
> > fs/nfsd/nfs4state.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> > index cc9705b..ad30039 100644
> > --- a/fs/nfsd/nfs4state.c
> > +++ b/fs/nfsd/nfs4state.c
> > @@ -1284,6 +1284,7 @@ out_new:
> > copy_verf(new, &verf);
> > copy_cred(&new->cl_cred, &rqstp->rq_cred);
> > new->cl_addr = ip_addr;
> > + new->cl_flavor = rqstp->rq_flavor;
> > gen_clid(new);
> > gen_confirm(new);
> > add_to_unconfirmed(new, strhashval);
>
> Most of the code here is duplicated between the 4.1 and 4.0 cases, and
> this is just adding a line that was already there in the 4.0 case.
(The
> same will be true for rembering the princpal in the RPCSEC_GSS case.)
> Could we move the rest of this initialization into create_client
(giving
> it some more arguments if necessary), and eliminate some code
> duplication?

Sounds good. I'll take care of that.

- ricardo

> --b.
>
> > --
> > 1.6.2.1
> >