From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mydaemon: remove closeall() calls from mydaemon()
Date: Mon, 29 Jun 2009 10:56:42 -0400 [thread overview]
Message-ID: <4A48D62A.5080302@RedHat.com> (raw)
In-Reply-To: <1245700238-3755-1-git-send-email-jlayton@redhat.com>
Jeff Layton wrote:
> idmapd and svcgssd have a mydaemon() routine that uses closeall() to
> close file descriptors. Unfortunately, they aren't using it correctly
> and it ends up closing the pipe that the child process uses to talk to
> its parent.
>
> Fix this by not using closeall() in this routine and instead, just close
> the file descriptors that we know need to be closed. If /dev/null can't
> be opened for some reason, then just have the child exit with a non-zero
> error.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Committed...
steved.
prev parent reply other threads:[~2009-06-29 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 19:50 [PATCH] mydaemon: remove closeall() calls from mydaemon() Jeff Layton
2009-06-29 14:56 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A48D62A.5080302@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox