From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, chuck.lever@oracle.com
Subject: Re: [PATCH 07/11] nfs-utils: convert nfssvc_setfds to use getaddrinfo
Date: Sat, 01 Aug 2009 07:35:50 -0400 [thread overview]
Message-ID: <4A742896.1010005@RedHat.com> (raw)
In-Reply-To: <1244484044-21355-8-git-send-email-jlayton@redhat.com>
On 06/08/2009 02:00 PM, Jeff Layton wrote:
> static void
> nfssvc_versbits(unsigned int ctlbits, int minorvers4)
> {
> @@ -180,8 +246,11 @@ nfssvc(int port, int nrservs, unsigned int versbits, int minorvers4,
> * the ports get registered with portmap against correct
> * versions
> */
> - nfssvc_versbits(versbits, minorvers4);
> - nfssvc_setfds(port, protobits, haddr);
> + if (!nfssvc_inuse()) {
> + nfssvc_versbits(versbits, minorvers4);
> + snprintf(buf, sizeof(buf), "%d", port);
> + nfssvc_set_sockets(AF_INET, protobits, haddr, portstr);
portstr is not defined here.... and as far as I can tell its not
defined in any of the next 3 patches either...
What am I missing or it is missing?
steved.
next prev parent reply other threads:[~2009-08-01 11:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 18:00 [PATCH 00/11] nfs-utils: add TIRPC/IPv6 support to rpc.nfsd Jeff Layton
2009-06-08 18:00 ` [PATCH 01/11] nfs-utils: move nfssvc.c to nfsd dir and clean up linking of nfsd Jeff Layton
2009-06-08 18:00 ` [PATCH 02/11] nfs-utils: clean up option parsing in nfsd.c Jeff Layton
2009-06-08 18:00 ` [PATCH 03/11] nfs-utils: convert rpc.nfsd to use xlog() Jeff Layton
2009-06-08 18:16 ` Chuck Lever
2009-06-08 18:23 ` Jeff Layton
[not found] ` <20090608142312.1e1ea273-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2009-06-08 18:25 ` Chuck Lever
2009-06-08 18:00 ` [PATCH 04/11] nfs-utils: clean up NFSCTL_* macros for handling protocol bits Jeff Layton
2009-06-08 18:00 ` [PATCH 05/11] nfs-utils: declare a static common buffer for nfssvc.c routines Jeff Layton
2009-06-08 18:22 ` Chuck Lever
2009-06-08 18:30 ` Jeff Layton
2009-06-08 18:00 ` [PATCH 06/11] nfs-utils: move check for active knfsd to helper function Jeff Layton
2009-06-08 18:00 ` [PATCH 07/11] nfs-utils: convert nfssvc_setfds to use getaddrinfo Jeff Layton
2009-08-01 11:35 ` Steve Dickson [this message]
[not found] ` <4A742896.1010005-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-08-01 12:45 ` Jeff Layton
[not found] ` <20090801084501.6fee9d06-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2009-08-01 13:08 ` Steve Dickson
2009-06-08 18:00 ` [PATCH 08/11] nfs-utils: break up the nfssvc interface Jeff Layton
2009-06-08 18:00 ` [PATCH 09/11] nfs-utils: add IPv6 support to nfssvc_setfds Jeff Layton
2009-06-08 18:00 ` [PATCH 10/11] nfs-utils: add IPv6 support to nfsd Jeff Layton
2009-06-08 18:00 ` [PATCH 11/11] nfs-utils: update the nfsd manpage and copyright notices Jeff Layton
2009-08-16 20:06 ` [PATCH 00/11] nfs-utils: add TIRPC/IPv6 support to rpc.nfsd Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A742896.1010005@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).