nfs MNT include cleanup

nfs MNT include cleanup

[maximilian attems]

2ad780978b7c0c3e7877949f098cbd06e7c73839 broke klibc build
MNTPROC_MNT and MNTPROC_UMNT no longer defined.

usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_call=E2=80=99:
usr/kinit/nfsmount/mount.c:179: error: =E2=80=98MNTPROC_MNT=E2=80=99 un=
declared (first use in this function)
usr/kinit/nfsmount/mount.c:179: error: (Each undeclared identifier is r=
eported only once
usr/kinit/nfsmount/mount.c:179: error: for each function it appears in.=
)
usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_v2=E2=80=99:
usr/kinit/nfsmount/mount.c:211: error: =E2=80=98MNTPROC_MNT=E2=80=99 un=
declared (first use in this function)
usr/kinit/nfsmount/mount.c: In function =E2=80=98umount_v2=E2=80=99:
usr/kinit/nfsmount/mount.c:226: error: =E2=80=98MNTPROC_UMNT=E2=80=99 u=
ndeclared (first use in this function)
usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_v3=E2=80=99:
usr/kinit/nfsmount/mount.c:232: error: =E2=80=98MNTPROC_MNT=E2=80=99 un=
declared (first use in this function)
usr/kinit/nfsmount/mount.c: In function =E2=80=98umount_v3=E2=80=99:
usr/kinit/nfsmount/mount.c:251: error: =E2=80=98MNTPROC_UMNT=E2=80=99 u=
ndeclared (first use in this function)
make[4]: *** [usr/kinit/nfsmount/mount.o] Error 1
make[3]: *** [usr/kinit/nfsmount] Error 2
make[2]: *** [all] Error 2
make[1]: *** [klibc] Error 2
make[1]: Leaving directory `/home/maks/src/klibc-latest'

Re: nfs MNT include cleanup

[Chuck Lever]

On Aug 11, 2009, at 6:44 AM, maximilian attems wrote:
> 2ad780978b7c0c3e7877949f098cbd06e7c73839 broke klibc build
> MNTPROC_MNT and MNTPROC_UMNT no longer defined.

I assume then that klibc is out of tree?  I can't find it in my kernel =
=20
repo.

> usr/kinit/nfsmount/mount.c: In function =91mount_call=92:
> usr/kinit/nfsmount/mount.c:179: error: =91MNTPROC_MNT=92 undeclared =20
> (first use in this function)
> usr/kinit/nfsmount/mount.c:179: error: (Each undeclared identifier =20
> is reported only once
> usr/kinit/nfsmount/mount.c:179: error: for each function it appears =20
> in.)
> usr/kinit/nfsmount/mount.c: In function =91mount_v2=92:
> usr/kinit/nfsmount/mount.c:211: error: =91MNTPROC_MNT=92 undeclared =20
> (first use in this function)
> usr/kinit/nfsmount/mount.c: In function =91umount_v2=92:
> usr/kinit/nfsmount/mount.c:226: error: =91MNTPROC_UMNT=92 undeclared =
=20
> (first use in this function)
> usr/kinit/nfsmount/mount.c: In function =91mount_v3=92:
> usr/kinit/nfsmount/mount.c:232: error: =91MNTPROC_MNT=92 undeclared =20
> (first use in this function)
> usr/kinit/nfsmount/mount.c: In function =91umount_v3=92:
> usr/kinit/nfsmount/mount.c:251: error: =91MNTPROC_UMNT=92 undeclared =
=20
> (first use in this function)
> make[4]: *** [usr/kinit/nfsmount/mount.o] Error 1
> make[3]: *** [usr/kinit/nfsmount] Error 2
> make[2]: *** [all] Error 2
> make[1]: *** [klibc] Error 2
> make[1]: Leaving directory `/home/maks/src/klibc-latest'

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Re: nfs MNT include cleanup

[maximilian attems]

On Tue, 11 Aug 2009, Chuck Lever wrote:

> On Aug 11, 2009, at 6:44 AM, maximilian attems wrote:
> >2ad780978b7c0c3e7877949f098cbd06e7c73839 broke klibc build
> >MNTPROC_MNT and MNTPROC_UMNT no longer defined.
>=20
> I assume then that klibc is out of tree?  I can't find it in my
> kernel repo.

sorry for late reply, indeed you'll find it here:
http://git.kernel.org/?p=3Dlibs/klibc/klibc.git;a=3Dsummary
=20
> >usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_call=E2=80=99=
:
> >usr/kinit/nfsmount/mount.c:179: error: =E2=80=98MNTPROC_MNT=E2=80=99=
 undeclared
> >(first use in this function)
> >usr/kinit/nfsmount/mount.c:179: error: (Each undeclared identifier
> >is reported only once
> >usr/kinit/nfsmount/mount.c:179: error: for each function it
> >appears in.)
> >usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_v2=E2=80=99:
> >usr/kinit/nfsmount/mount.c:211: error: =E2=80=98MNTPROC_MNT=E2=80=99=
 undeclared
> >(first use in this function)
> >usr/kinit/nfsmount/mount.c: In function =E2=80=98umount_v2=E2=80=99:
> >usr/kinit/nfsmount/mount.c:226: error: =E2=80=98MNTPROC_UMNT=E2=80=99=
 undeclared
> >(first use in this function)
> >usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_v3=E2=80=99:
> >usr/kinit/nfsmount/mount.c:232: error: =E2=80=98MNTPROC_MNT=E2=80=99=
 undeclared
> >(first use in this function)
> >usr/kinit/nfsmount/mount.c: In function =E2=80=98umount_v3=E2=80=99:
> >usr/kinit/nfsmount/mount.c:251: error: =E2=80=98MNTPROC_UMNT=E2=80=99=
 undeclared
> >(first use in this function)
> >make[4]: *** [usr/kinit/nfsmount/mount.o] Error 1
> >make[3]: *** [usr/kinit/nfsmount] Error 2
> >make[2]: *** [all] Error 2
> >make[1]: *** [klibc] Error 2
> >make[1]: Leaving directory `/home/maks/src/klibc-latest'

we might still define those for ourselve, let's see..

Re: nfs MNT include cleanup

[Chuck Lever]

On Aug 18, 2009, at 6:36 AM, maximilian attems wrote:
> On Tue, 11 Aug 2009, Chuck Lever wrote:
>
>> On Aug 11, 2009, at 6:44 AM, maximilian attems wrote:
>>> 2ad780978b7c0c3e7877949f098cbd06e7c73839 broke klibc build
>>> MNTPROC_MNT and MNTPROC_UMNT no longer defined.
>>
>> I assume then that klibc is out of tree?  I can't find it in my
>> kernel repo.
>
> sorry for late reply, indeed you'll find it here:
> http://git.kernel.org/?p=3Dlibs/klibc/klibc.git;a=3Dsummary
>
>>> usr/kinit/nfsmount/mount.c: In function =91mount_call=92:
>>> usr/kinit/nfsmount/mount.c:179: error: =91MNTPROC_MNT=92 undeclared
>>> (first use in this function)
>>> usr/kinit/nfsmount/mount.c:179: error: (Each undeclared identifier
>>> is reported only once
>>> usr/kinit/nfsmount/mount.c:179: error: for each function it
>>> appears in.)
>>> usr/kinit/nfsmount/mount.c: In function =91mount_v2=92:
>>> usr/kinit/nfsmount/mount.c:211: error: =91MNTPROC_MNT=92 undeclared
>>> (first use in this function)
>>> usr/kinit/nfsmount/mount.c: In function =91umount_v2=92:
>>> usr/kinit/nfsmount/mount.c:226: error: =91MNTPROC_UMNT=92 undeclare=
d
>>> (first use in this function)
>>> usr/kinit/nfsmount/mount.c: In function =91mount_v3=92:
>>> usr/kinit/nfsmount/mount.c:232: error: =91MNTPROC_MNT=92 undeclared
>>> (first use in this function)
>>> usr/kinit/nfsmount/mount.c: In function =91umount_v3=92:
>>> usr/kinit/nfsmount/mount.c:251: error: =91MNTPROC_UMNT=92 undeclare=
d
>>> (first use in this function)
>>> make[4]: *** [usr/kinit/nfsmount/mount.o] Error 1
>>> make[3]: *** [usr/kinit/nfsmount] Error 2
>>> make[2]: *** [all] Error 2
>>> make[1]: *** [klibc] Error 2
>>> make[1]: Leaving directory `/home/maks/src/klibc-latest'
>
> we might still define those for ourselve, let's see..

That makes sense to me as an immediate fix.

However, the kernel has its own NFS mount client (the piece that =20
handles rpcbind query and obtaining the root file handle), and you can =
=20
pass a C string of mount options to the kernel with mount(2).  Perhaps =
=20
in the long term, you might consider replacing the specialized code in =
=20
klibc with simply passing the server, export path, and mount options =20
right to the kernel and let it do the work.  This should work with any =
=20
kernel later than 2.6.23.

I'm happy to help with any questions.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Re: nfs MNT include cleanup

[maximilian attems]

On Tue, Aug 18, 2009 at 08:45:49AM -0400, Chuck Lever wrote:
> 
> However, the kernel has its own NFS mount client (the piece that  
> handles rpcbind query and obtaining the root file handle), and you can  
> pass a C string of mount options to the kernel with mount(2).  Perhaps  
> in the long term, you might consider replacing the specialized code in  
> klibc with simply passing the server, export path, and mount options  
> right to the kernel and let it do the work.  This should work with any  
> kernel later than 2.6.23.
> 
> I'm happy to help with any questions.

sounds good indeed.
a quick one: can it do nfs v4 mounts?

Re: nfs MNT include cleanup

[Chuck Lever]

On Aug 18, 2009, at 8:44 AM, maximilian attems wrote:
> On Tue, Aug 18, 2009 at 08:45:49AM -0400, Chuck Lever wrote:
>>
>> However, the kernel has its own NFS mount client (the piece that
>> handles rpcbind query and obtaining the root file handle), and you  
>> can
>> pass a C string of mount options to the kernel with mount(2).   
>> Perhaps
>> in the long term, you might consider replacing the specialized code  
>> in
>> klibc with simply passing the server, export path, and mount options
>> right to the kernel and let it do the work.  This should work with  
>> any
>> kernel later than 2.6.23.
>>
>> I'm happy to help with any questions.
>
> sounds good indeed.
> a quick one: can it do nfs v4 mounts?

Yes, in fact.  Set the file system type to "nfs4" instead of "nfs"  
when invoking mount(2).

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Re: [klibc] nfs MNT include cleanup

[H. Peter Anvin]

On 08/18/2009 05:44 AM, maximilian attems wrote:
> On Tue, Aug 18, 2009 at 08:45:49AM -0400, Chuck Lever wrote:
>> However, the kernel has its own NFS mount client (the piece that  
>> handles rpcbind query and obtaining the root file handle), and you can  
>> pass a C string of mount options to the kernel with mount(2).  Perhaps  
>> in the long term, you might consider replacing the specialized code in  
>> klibc with simply passing the server, export path, and mount options  
>> right to the kernel and let it do the work.  This should work with any  
>> kernel later than 2.6.23.
>>
>> I'm happy to help with any questions.
> 
> sounds good indeed.
> a quick one: can it do nfs v4 mounts?
> 

I believe that was the reason for the change in the first place, and
yes, klibc should *absolutely* use it.

	-hpa (who once again apologizes for lack of time...)

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.