From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:26530 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752564AbZHZSDU (ORCPT ); Wed, 26 Aug 2009 14:03:20 -0400 Message-ID: <4A9578E4.4040402@RedHat.com> Date: Wed, 26 Aug 2009 14:03:16 -0400 From: Steve Dickson To: Chuck Lever CC: Lans Carstensen , NFS list Subject: Re: [PATCH 2/4] nfs-utils: nfs-iostat.py autofs cleanup and option to sort by ops/s References: <4A94C133.8030904@dreamworks.com> <3644941A-3EA7-4755-867A-888E81A372FC@oracle.com> <4A9550FF.6010103@RedHat.com> <52E7928C-340C-45EF-9CFF-FB902332465F@oracle.com> In-Reply-To: <52E7928C-340C-45EF-9CFF-FB902332465F@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On 08/26/2009 11:35 AM, Chuck Lever wrote: > On Aug 26, 2009, at 11:13 AM, Steve Dickson wrote: >> On 08/26/2009 10:28 AM, Chuck Lever wrote: >>> >>> On Aug 26, 2009, at 12:59 AM, Lans Carstensen wrote: >>> >>>> commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e >>>> Author: Lans Carstensen >>>> Date: Tue Aug 25 21:52:03 2009 -0700 >>>> >>>> Bump nfs-iostat.py version up to 0.3 to reflect new features. >>> >>> Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure >>> we want to maintain an individual version number for it. Maybe it >>> should use the nfs-utils package's versioning instead... Steve, your >>> thoughts? >> Hmm... I don't think we tie any of other commands versions to >> the package version.... > > Actually many of the C commands do grab a macro defined during > autoconfiguration: PACKAGE_VERSION. > Interesting.. I do see PACKAGE_VERSION being defined in support/include/config.h I guess I didn't know that was there and it does not seem to be used by anybody... which is probably a problem but I don't think its a problem with this script... steved.