From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH 1/2] mount: ECONNREFUSED is a permanent error Date: Fri, 09 Oct 2009 11:20:20 -0400 Message-ID: <4ACF54B4.9020900@RedHat.com> References: <20091008173520.12619.10662.stgit@matisse.1015granger.net> <20091008173703.12619.35788.stgit@matisse.1015granger.net> <4ACF37C2.6030208@RedHat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-nfs@vger.kernel.org, Ian Kent To: Chuck Lever Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63709 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932230AbZJIPVA (ORCPT ); Fri, 9 Oct 2009 11:21:00 -0400 In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On 10/09/2009 11:13 AM, Chuck Lever wrote: > On Oct 9, 2009, at 9:16 AM, Steve Dickson wrote: >> On 10/08/2009 01:37 PM, Chuck Lever wrote: >>> I had assumed early on that mount.nfs should retry a refused connection. >>> >>> Apparently this is not the case. Legacy mount.nfs4 fails immediately >>> if the NFS server refuses the connection. Legacy mount.nfs and >>> text-based mount.nfs both fail immediately if the rpcbind service is >>> refusing connections. >>> >> What about if the server is on the way up (i.e the network is up) >> but has not started the NFS service? In that window, the server will >> return ECONNREFUSED since nobody is listening, but in a very short time >> there will be a listener... The mount should not fail in that case... > > I agree, but I think it does fail today, and it has behaved this way for > a long while. No one has complained about it. I'm actually not arguing > in favor of either behavior; just reporting that the current behavior is > inconsistent. > > With the current code, legacy and text-based v2/v3 fails immediately if > the server's rpcbind refuses connection... Legacy mount.nfs4 fails > immediately if the NFS server refuses connection. Text-based mount.nfs4 > retries in this case. I think the text-based mounts have it right... > > So we will either need to fix v2/v3 to continue retrying, or fix NFSv4 > to stop retrying. The retries would stop after mount.nfs's retry timer > expires (just like the case where the server isn't responding at all). The former, IMHO.. I also notice that the retry timer does not work since the mount waits in the kernel well passed the timer expiring... > > Automounter might want different behavior in this case, but we should > ask around before making a final decision, probably. Ian... What do you think?? steved.