public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Staubach <staubach@redhat.com>
To: Olaf Kirch <okir@suse.de>
Cc: Andreas Gruenbacher <agruen@suse.de>,
	NFS list <linux-nfs@vger.kernel.org>,
	"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH v2] register NFS_ACL with rpcbind
Date: Tue, 03 Nov 2009 10:28:42 -0500	[thread overview]
Message-ID: <4AF04C2A.4020203@redhat.com> (raw)
In-Reply-To: <200911031017.41564.okir@suse.de>

Olaf Kirch wrote:
> On Tuesday 03 November 2009 10:13:27 Andreas Gruenbacher wrote:
>> I don't understand the reasoning behind .vs_hidden for NFS_ACL, hopefully
>> Olaf can clarify. NFS_ACL is the only user of .vs_hidden as far as I can
>> see though, so if this is changeg, shouldn't the entire commit bc5fea4
>> which introduced the flag be reverted?
> 
> I can't remember the details of that one. I do remember that this is
> based on someone's request who told me that we shouldn't register nfsacl
> with portmap. I didn't check myself whether Solaris did or did not do
> it at that time.
> 
> I have no issue with reverting that change, and removing the whole
> .vs_hidden kludge too.
> 

It seems that vs_hidden is used in 1 place outside of the NFS_ACL
server code.  It is used in the NFSv4 callback code.

I will look to see how difficult that might be to fix this spot
as well and then get rid of vs_hidden.

	Thanx...

		ps

  reply	other threads:[~2009-11-03 15:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 19:03 [PATCH] register NFS_ACL with rpcbind Peter Staubach
2009-11-02 21:59 ` [PATCH v2] " Peter Staubach
2009-11-03  9:13   ` Andreas Gruenbacher
2009-11-03  9:17     ` Olaf Kirch
2009-11-03 15:28       ` Peter Staubach [this message]
2009-11-03 15:34         ` Chuck Lever
2009-11-04 18:44           ` Peter Staubach
2009-11-04 19:45             ` Chuck Lever
2009-11-04 18:58   ` J. Bruce Fields
2009-11-04 19:54     ` Peter Staubach
2009-11-05 16:56       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF04C2A.4020203@redhat.com \
    --to=staubach@redhat.com \
    --cc=agruen@suse.de \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=okir@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox