From: Steve Dickson <SteveD@redhat.com>
To: Robert Gordon <rbg-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [RFC][PATCH] relax insecure option on mountd (ver 2)
Date: Mon, 16 Nov 2009 13:26:19 -0500 [thread overview]
Message-ID: <4B01994B.3010202@RedHat.com> (raw)
In-Reply-To: <DE1C4ECC-6D4A-4EA6-A4FB-BE76E31C4A40-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org>
On 10/26/2009 05:40 PM, Robert Gordon wrote:
> In nfs-utils 1.2.0, I noticed that the insecure option validates that
> the client port is a
> subset of IPPORT_RESERVED as opposed to just validating it is a valid
> reserved port. The following proposed patch would correct that issue.
>
> Signed-off-by: Robert Gordon <rbg-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org>
>
> --- ./utils/mountd/auth.c.orig
> +++ ./utils/mountd/auth.c
> @@ -169,8 +169,7 @@ auth_authenticate_internal(char *what, s
> }
> }
> if (!(exp->m_export.e_flags & NFSEXP_INSECURE_PORT) &&
> - (ntohs(caller->sin_port) < IPPORT_RESERVED/2 ||
> - ntohs(caller->sin_port) >= IPPORT_RESERVED)) {
> + ntohs(caller->sin_port) >= IPPORT_RESERVED) {
> *error = illegal_port;
> return NULL;
> }
>
Committed...
steved.
prev parent reply other threads:[~2009-11-16 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 21:40 [RFC][PATCH] relax insecure option on mountd (ver 2) Robert Gordon
[not found] ` <DE1C4ECC-6D4A-4EA6-A4FB-BE76E31C4A40-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org>
2009-11-16 18:26 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B01994B.3010202@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rbg-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox