public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Mi Jinlong <mijinlong@cn.fujitsu.com>
To: "Trond.Myklebust" <trond.myklebust@fys.uio.no>,
	NFSv3 list <linux-nfs@vger.kernel.org>,
	"J. Bruce Fields" <bfields@fieldses.org>
Subject: [RFC] After server stop nfslock service, client still can get lock success
Date: Tue, 17 Nov 2009 17:47:15 +0800	[thread overview]
Message-ID: <4B027123.4060100@cn.fujitsu.com> (raw)

When testing NLM, i find a bug.
After server stop nfslock service, client still can get lock success

Test process:

  Step1: client open nfs file.
  Step2: client using fcntl to get lock.
  Step3: client using fcntl to release lock.
  Step4: service stop it's nfslock service.
  Step5: client using fcntl to get lock again.

At step5, client should get lock fail, but it's success.

Reason:
  When server stop nfslock service, client's host struct not be
  unmonitor at server. When client get lock again, the client's
  host struct will be reuse but don't monitor again. 
  So that, at step5 client can get lock success.

Question:
  1. Should unmonitor the client's host struct at server 
     when server stop nfslock service ?

  2. Whether let rpc.statd tell kernel it's status(when start and stop)
     by send a SM_NOTIFY ?

-- 
Regards
Mi Jinlong



             reply	other threads:[~2009-11-17  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17  9:47 Mi Jinlong [this message]
2009-11-17 15:34 ` [RFC] After server stop nfslock service, client still can get lock success Chuck Lever
2009-11-18  9:50   ` Mi Jinlong
2009-11-18 17:03     ` Chuck Lever
2009-11-19  9:48       ` Mi Jinlong
2009-11-19 15:41         ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B027123.4060100@cn.fujitsu.com \
    --to=mijinlong@cn.fujitsu.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox