* [PATCH] libexport.a: fix a long-standing typo in name_cmp()
@ 2009-12-11 21:27 Chuck Lever
[not found] ` <20091211212608.29241.27167.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Chuck Lever @ 2009-12-11 21:27 UTC (permalink / raw)
To: neilb; +Cc: linux-nfs
Not sure what "(!*a || !a == ',')" means... but just a few lines later is
"(!*a || *a == ',')". I think "a is '\0' or ','" is what was intended.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
Neil --
Looks like a typo. Comments?
support/export/client.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/support/export/client.c b/support/export/client.c
index b08dda2..cb6e659 100644
--- a/support/export/client.c
+++ b/support/export/client.c
@@ -266,7 +266,7 @@ name_cmp(char *a, char *b)
/* compare strings a and b, but only upto ',' in a */
while (*a && *b && *a != ',' && *a == *b)
a++, b++;
- if (!*b && (!*a || !a == ',') )
+ if (!*b && (!*a || *a == ','))
return 0;
if (!*b) return 1;
if (!*a || *a == ',') return -1;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libexport.a: fix a long-standing typo in name_cmp()
[not found] ` <20091211212608.29241.27167.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
@ 2009-12-23 19:40 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2009-12-23 19:40 UTC (permalink / raw)
To: Chuck Lever; +Cc: neilb, linux-nfs
On 12/11/2009 04:27 PM, Chuck Lever wrote:
> Not sure what "(!*a || !a == ',')" means... but just a few lines later is
> "(!*a || *a == ',')". I think "a is '\0' or ','" is what was intended.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> Neil --
>
> Looks like a typo. Comments?
>
> support/export/client.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/support/export/client.c b/support/export/client.c
> index b08dda2..cb6e659 100644
> --- a/support/export/client.c
> +++ b/support/export/client.c
> @@ -266,7 +266,7 @@ name_cmp(char *a, char *b)
> /* compare strings a and b, but only upto ',' in a */
> while (*a && *b && *a != ',' && *a == *b)
> a++, b++;
> - if (!*b && (!*a || !a == ',') )
> + if (!*b && (!*a || *a == ','))
> return 0;
> if (!*b) return 1;
> if (!*a || *a == ',') return -1;
>
Committed...
steved.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-23 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-11 21:27 [PATCH] libexport.a: fix a long-standing typo in name_cmp() Chuck Lever
[not found] ` <20091211212608.29241.27167.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-12-23 19:40 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).