[PATCH] libexport.a: fix a long-standing typo in name_cmp()

[PATCH] libexport.a: fix a long-standing typo in name_cmp()

[Chuck Lever]

Not sure what "(!*a || !a == ',')" means... but just a few lines later is
"(!*a || *a == ',')".  I think "a is '\0' or ','" is what was intended.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

Neil --

Looks like a typo.  Comments?

 support/export/client.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/support/export/client.c b/support/export/client.c
index b08dda2..cb6e659 100644
--- a/support/export/client.c
+++ b/support/export/client.c
@@ -266,7 +266,7 @@ name_cmp(char *a, char *b)
 	/* compare strings a and b, but only upto ',' in a */
 	while (*a && *b && *a != ',' && *a == *b)
 		a++, b++;
-	if (!*b && (!*a || !a == ',') )
+	if (!*b && (!*a || *a == ','))
 		return 0;
 	if (!*b) return 1;
 	if (!*a || *a == ',') return -1;

Re: [PATCH] libexport.a: fix a long-standing typo in name_cmp()

[Steve Dickson]

On 12/11/2009 04:27 PM, Chuck Lever wrote:
> Not sure what "(!*a || !a == ',')" means... but just a few lines later is
> "(!*a || *a == ',')".  I think "a is '\0' or ','" is what was intended.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
> Neil --
> 
> Looks like a typo.  Comments?
> 
>  support/export/client.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/support/export/client.c b/support/export/client.c
> index b08dda2..cb6e659 100644
> --- a/support/export/client.c
> +++ b/support/export/client.c
> @@ -266,7 +266,7 @@ name_cmp(char *a, char *b)
>  	/* compare strings a and b, but only upto ',' in a */
>  	while (*a && *b && *a != ',' && *a == *b)
>  		a++, b++;
> -	if (!*b && (!*a || !a == ',') )
> +	if (!*b && (!*a || *a == ','))
>  		return 0;
>  	if (!*b) return 1;
>  	if (!*a || *a == ',') return -1;
> 
Committed...

steved.