linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mount.nfs: don't use IPv6 unless IPV6_SUPPORTED is set
@ 2010-01-04 19:47 Jeff Layton
  2010-01-04 20:44 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2010-01-04 19:47 UTC (permalink / raw)
  To: steved; +Cc: linux-nfs, chuck.lever

Commit 1f3fae1fb25168aac187ff1881738c8ad53a8763 made mount.nfs start
looking up and trying to use IPv6 addresses when mount.nfs was built
against libtirpc (even when --enable-ipv6 wasn't specified).

The problem seems to be that nfs_nfs_proto_family() is basing the family
on HAVE_LIBTIRPC. I think it should be basing it on IPV6_SUPPORTED
instead.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Chuck Lever <chuck.lever@oracle.com>
---
 utils/mount/network.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/utils/mount/network.c b/utils/mount/network.c
index e3ad5c2..906e20c 100644
--- a/utils/mount/network.c
+++ b/utils/mount/network.c
@@ -1344,7 +1344,7 @@ int nfs_nfs_proto_family(struct mount_options *options,
 	unsigned long protocol;
 	char *option;
 
-#ifdef HAVE_LIBTIRPC
+#ifdef IPV6_SUPPORTED
 	*family = AF_UNSPEC;
 #else
 	*family = AF_INET;
-- 
1.6.5.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mount.nfs: don't use IPv6 unless IPV6_SUPPORTED is set
  2010-01-04 19:47 [PATCH] mount.nfs: don't use IPv6 unless IPV6_SUPPORTED is set Jeff Layton
@ 2010-01-04 20:44 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2010-01-04 20:44 UTC (permalink / raw)
  To: Jeff Layton; +Cc: linux-nfs, chuck.lever



On 01/04/2010 02:47 PM, Jeff Layton wrote:
> Commit 1f3fae1fb25168aac187ff1881738c8ad53a8763 made mount.nfs start
> looking up and trying to use IPv6 addresses when mount.nfs was built
> against libtirpc (even when --enable-ipv6 wasn't specified).
> 
> The problem seems to be that nfs_nfs_proto_family() is basing the family
> on HAVE_LIBTIRPC. I think it should be basing it on IPV6_SUPPORTED
> instead.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> Acked-by: Chuck Lever <chuck.lever@oracle.com>
Committed...

steved.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-04 20:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-04 19:47 [PATCH] mount.nfs: don't use IPv6 unless IPV6_SUPPORTED is set Jeff Layton
2010-01-04 20:44 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).