From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mount: Set protocol family properly for "udp" and "tcp"
Date: Thu, 18 Feb 2010 06:45:01 -0500 [thread overview]
Message-ID: <4B7D283D.9000905@RedHat.com> (raw)
In-Reply-To: <20100216221010.2977.6043.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On 02/16/2010 05:10 PM, Chuck Lever wrote:
> In nfs_nfs_proto_family(), *family is never set if the legacy
> "udp" or "tcp" mount options are specified. The result is an error
> message at umount time, for example:
>
> umount.nfs: DNS resolution failed for
> 2001:5c0:1101:2f00:250:8dff:fe95:5c61: ai_family not supported
>
> even if mount was built with IPv6 support.
>
> The man page says that "udp" is a synonym for "proto=udp", and
> likewise for "tcp". Thus, we don't look at config_default_family
> here, but always use AF_INET explicitly, to be consistent with the
> meaning of proto=.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> Reviewed-by: Jeff Layton <jlayton@redhat.com>
> ---
Committed...
steved.
prev parent reply other threads:[~2010-02-18 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 22:10 [PATCH] mount: Set protocol family properly for "udp" and "tcp" Chuck Lever
[not found] ` <20100216221010.2977.6043.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-02-18 11:45 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7D283D.9000905@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox